Repository navigation
Honor changeOrigin for WebSocket upgrades - #979
Open
raashish1601 wants to merge 1 commit into
Open
raashish1601 wants to merge 1 commit into
raashish1601 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WebSocket upgrades still force
changeOrigin: true, soproxyOptions.changeOrigin: falseonly affects normal HTTP requests. Remove the per-upgrade override so WebSockets inherit the same proxy configuration as HTTP. The default remainstrue.Add real loopback WebSocket handshakes that check the Host received by the upstream server for default, explicitly enabled, and disabled
changeOrigin.Validation on Windows with Node 24.12.0:
npm test -- --jobs=1: 530 passed, 0 failed, 1 skipped.An initial full run encountered a CLI socket hangup. The pristine CLI suite (40 assertions) and unchanged full rerun passed; no timeout or DNS configuration was changed.
Relevant issues
Fixes #965.
Contributor checklist
--helpoutputmasterbranchAI assistance: Codex assisted with investigation, implementation, and validation.
Maintainer checklist