Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when
users.htmland ausers/directory coexist,/usersalways redirects to the directory, making the extensionless page unreachable. try a readable sibling file with the configured default extension before handling an extensionless directory request./users/continues to address the directory explicitly. if there is no matching sibling file, keep directory redirects and listings. carry the request method and query string into the file lookup.fixes #629.
validation:
npm testpasses all 547 assertions across 43 suites on macos with node 26. regression coverage includes the collision, query strings, explicit directory access, child pages, missing sibling files, a custom extension andhead. the collision cases fail before the fix.git diff --checkpasses.