Refactor FUNCTIONBAR_MAXEVENTS and use sentinels in loops#1910
Open
natoscott wants to merge 1 commit intohtop-dev:mainfrom
Open
Refactor FUNCTIONBAR_MAXEVENTS and use sentinels in loops#1910natoscott wants to merge 1 commit intohtop-dev:mainfrom
natoscott wants to merge 1 commit intohtop-dev:mainfrom
Conversation
Set FUNCTIONBAR_MAXEVENTS to the actual limit (11) and adjust the loops which use it to solely rely on sentinel NULL, removing checks for a situation which cannot occur. Fixes covscan issue #644308
Explorer09
reviewed
Feb 20, 2026
| for (size_t i = 0; i < FUNCTIONBAR_MAXEVENTS && functions[i]; i++) { | ||
| for (size_t i = 0; functions[i]; i++) { | ||
| this->functions[i] = xStrdup(functions[i]); | ||
| } |
Contributor
There was a problem hiding this comment.
Maybe add an assert here: assert(i <= FUNCTIONBAR_MAXEVENTS);
Explorer09
reviewed
Feb 20, 2026
| this->keys.keys[i] = xStrdup(keys[i]); | ||
| this->events[i] = events[i]; | ||
| i++; | ||
| i++; |
Contributor
There was a problem hiding this comment.
This space-to-tab change is probably unintentional.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set FUNCTIONBAR_MAXEVENTS to the actual limit (11) and adjust the loops which use it to solely rely on sentinel NULL, removing checks for a situation which cannot occur.
Fixes covscan issue #644308