Disable user name lookup in static builds against glibc#1527
Draft
cgzones wants to merge 1 commit intohtop-dev:mainfrom
Draft
Disable user name lookup in static builds against glibc#1527cgzones wants to merge 1 commit intohtop-dev:mainfrom
cgzones wants to merge 1 commit intohtop-dev:mainfrom
Conversation
Static linking against glibc might crash due to usage of NSS modules, e.g. via getpwuid() (see htop-dev#503). The linker also warns about it: warning: Using 'getpwuid' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking
BenBE
approved these changes
Aug 24, 2024
Member
|
@cgzones Anything still missing here? |
Member
Author
|
There might be still hidden usage of NSS modules, e.g. a static build reports: Maybe it's best to recommend not using static builds on Linux against glibc? |
Member
|
Can we check for |
Member
|
I think we need to replace these NSS / getpwuid uses with alternate implementations. Can't have a static Moving to the 3.5.0 milestone. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Static linking against glibc might crash due to usage of NSS modules, e.g. via getpwuid() (see #503).
The linker also warns about it: