Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setValue() fails when tags mode is enabled on advanced selects. #533

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

OmkarOza
Copy link
Contributor

Hello @olegpix,

Issue: Console Errors with setValue() method #444 (comment)

When executing the example without applying the necessary fixes, I encounter console errors related to the setValue() method. You can view the error occurrence in the following video:

WithoutUpdatedCode.mp4

Reason:
The setValue() method does not handle cases where the select component has tags mode enabled. This omission results in the observed console errors.

Resolution: Updated Select Plugin

After updating the select plugin, the console errors are resolved. The successful implementation is demonstrated in the video below:

WithUpdatedCode.mp4

@PruthviPraj00
Copy link
Contributor

Hello @olegpix,

This looks good. Will it be merged?

@jahaganiev
Copy link
Member

Thanks for the PR @OmkarOza!

@PruthviPraj00 PR is included to v2.7.0 release.

@jahaganiev jahaganiev merged commit 117a9b9 into htmlstreamofficial:main Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants