Add some tests to match changes made in new ruby model #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Critic review: https://critic.hoppipolla.co.uk/r/458 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
Just to be entirely clear: I don't suggest taking this PR before it's actually been implemented (or clearly in the process of being implemented). |
ghost
assigned
elima
pushed a commit
to Igalia/webkit
that referenced
this pull request
Apr 17, 2014
https://bugs.webkit.org/show_bug.cgi?id=131175 Patch by Koji Ishii <kojishi@gmail.com> on 2014-04-17 Reviewed by Darin Adler. Source/WebCore: Tests: html5lib/resources/ruby.dat html5lib/resources/tests19.dat This patch makes WebKit HTML parser to match to the tag omission rules of HTML5 CR Feb 2014: http://www.w3.org/TR/2014/CR-html5-20140204/syntax.html#syntax-tag-omission with the support for two new elements (rb, rtc) which were also defined in the spec: http://www.w3.org/TR/2014/CR-html5-20140204/text-level-semantics.html#the-rb-element http://www.w3.org/TR/2014/CR-html5-20140204/text-level-semantics.html#the-rtc-element to better support use cases presented by W3C I18N WG: http://www.w3.org/TR/ruby-use-cases/ * html/HTMLTagNames.in: rb and rtc added as HTMLElement interfaces. * html/parser/HTMLConstructionSite.cpp: (WebCore::hasImpliedEndTag): the spec says rb and rtc have implied end tags. * html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTagForInBody): rb and rtc added. rt excludes rtc from its implied end tags. LayoutTests: 25 new test cases in 2 test files imported from pull requests to html5lib-tests, with run- and expected-files generated. All new tests pass with the changes included in this patch. * html5lib/generated/run-ruby-data-expected.txt: Added. * html5lib/generated/run-ruby-data.html: Added (generated by generate-test-wrappers.py) * html5lib/generated/run-ruby-write-expected.txt: Added. * html5lib/generated/run-ruby-write.html: Added (generated by generate-test-wrappers.py) * html5lib/resources/ruby.dat: Added from darobin/html5lib-tests#1 * html5lib/resources/tests19.dat: Updated from html5lib/html5lib-tests#27 git-svn-id: http://svn.webkit.org/repository/webkit/trunk@167437 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Additional test cases for new ruby model
|
This is in WebKit at least, AFAICT. Time to more seriously consider landing this, @darobin? |
|
Yes, it's in WebKit and there's a patch on the way in Gecko. I have heard interest from the others, as well (but I'm not aware of anything being available at this point). I'm certainly happy for it to land, along with the python parser changes and the web-platform-test import (which'll need regeneration)! |
|
wchen has reviewed all the gecko patches and they're just waiting for him to commit them |
jgraham
added a commit
that referenced
this pull request
Aug 18, 2014
Add some tests to match changes made in new ruby model
This was referenced Aug 18, 2014
ryanhaddad
pushed a commit
to WebKit/WebKit
that referenced
this pull request
Dec 22, 2020
https://bugs.webkit.org/show_bug.cgi?id=131175 Patch by Koji Ishii <kojishi@gmail.com> on 2014-04-17 Reviewed by Darin Adler. Source/WebCore: Tests: html5lib/resources/ruby.dat html5lib/resources/tests19.dat This patch makes WebKit HTML parser to match to the tag omission rules of HTML5 CR Feb 2014: http://www.w3.org/TR/2014/CR-html5-20140204/syntax.html#syntax-tag-omission with the support for two new elements (rb, rtc) which were also defined in the spec: http://www.w3.org/TR/2014/CR-html5-20140204/text-level-semantics.html#the-rb-element http://www.w3.org/TR/2014/CR-html5-20140204/text-level-semantics.html#the-rtc-element to better support use cases presented by W3C I18N WG: http://www.w3.org/TR/ruby-use-cases/ * html/HTMLTagNames.in: rb and rtc added as HTMLElement interfaces. * html/parser/HTMLConstructionSite.cpp: (WebCore::hasImpliedEndTag): the spec says rb and rtc have implied end tags. * html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTagForInBody): rb and rtc added. rt excludes rtc from its implied end tags. LayoutTests: 25 new test cases in 2 test files imported from pull requests to html5lib-tests, with run- and expected-files generated. All new tests pass with the changes included in this patch. * html5lib/generated/run-ruby-data-expected.txt: Added. * html5lib/generated/run-ruby-data.html: Added (generated by generate-test-wrappers.py) * html5lib/generated/run-ruby-write-expected.txt: Added. * html5lib/generated/run-ruby-write.html: Added (generated by generate-test-wrappers.py) * html5lib/resources/ruby.dat: Added from darobin/html5lib-tests#1 * html5lib/resources/tests19.dat: Updated from html5lib/html5lib-tests#27 Canonical link: https://commits.webkit.org/149867@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167437 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per http://darobin.github.io/html-ruby/. This change is being landed in the W3C specification, apply with caution.