Skip to content

Lint fixes #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jan 12, 2016
Merged

Lint fixes #222

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
40c3ba6
Fix lint to expect text_type everywhere
gsnedders Dec 16, 2015
fbbea1f
Update lint filter for namespaced attributes
gsnedders Dec 16, 2015
8b4d7c4
Drop the content model requirements from lint
gsnedders Dec 16, 2015
270a2ca
Don't let the lxml treewalker walk above the fragment root
gsnedders Dec 16, 2015
66ef026
Teach lint & treewalkers that elements are only void in HTML ns
gsnedders Dec 16, 2015
5bd3413
Use lint filter to ensure validity of treewalkers
gsnedders Dec 16, 2015
fb9e177
Remove runtime type checks from treewalkers._base
gsnedders Dec 16, 2015
2a5d7af
Make sure we have the unicode from of text in lxml fragment root
gsnedders Dec 16, 2015
9eff304
Allow None as a doctype tagname in lint
gsnedders Dec 16, 2015
e0ea899
Drop all the to_text magic in treewalkers._base
gsnedders Dec 16, 2015
22c2b1a
Get rid of LintError and just use asserts
gsnedders Dec 16, 2015
5336ebe
Lint that comments are text_type
gsnedders Dec 16, 2015
dc879ff
Don't allow ParseError/SerializerError tokens, whatever they are!
gsnedders Dec 16, 2015
7f8bd13
Drop end tag tree walker's data (always empty now)
gsnedders Dec 16, 2015
c335295
Drop tree walker doctype correct flag, whatever that once was!
gsnedders Dec 16, 2015
ca6591c
Make sure lint is testing everything treewalkers can do.
gsnedders Dec 16, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Don't let the lxml treewalker walk above the fragment root
  • Loading branch information
@gsnedders
gsnedders committed Jan 12, 2016
commit 270a2ca14fafc989f8f1bd4f79db2f4bd9f4d1fc
4 changes: 4 additions & 0 deletions html5lib/treewalkers/lxmletree.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,8 +118,10 @@ def __len__(self):
class TreeWalker(_base.NonRecursiveTreeWalker):
def __init__(self, tree):
if hasattr(tree, "getroot"):
self.fragmentChildren = set()
tree = Root(tree)
elif isinstance(tree, list):
self.fragmentChildren = set(tree)
tree = FragmentRoot(tree)
_base.NonRecursiveTreeWalker.__init__(self, tree)
self.filter = ihatexml.InfosetFilter()
Expand Down Expand Up @@ -197,5 +199,7 @@ def getParentNode(self, node):
if key == "text":
return node
# else: fallback to "normal" processing
elif node in self.fragmentChildren:
return None

return node.getparent()