Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CHORE] Update ember-qunit to fix the build #259

Closed
wants to merge 1 commit into from
Closed

[CHORE] Update ember-qunit to fix the build #259

wants to merge 1 commit into from

Conversation

cyril-sf
Copy link
Contributor

@cyril-sf cyril-sf commented Apr 25, 2019 •
edited
Loading

Master is red I believe for a similar problem that I solved: the log gets too big.

Screen Shot 2019-04-24 at 5 57 02 PM

WARN: DEPRECATION: Using Ember.$() has been deprecated, use `import jQuery from 'jquery';` instead [deprecation id: ember-views.curly-components.jquery-element] See https://emberjs.com/deprecations/v3.x#toc_jquery-apis for more details.
           at logDeprecationStackTrace (http://localhost:7357/assets/vendor.js:46725:23)
           at HANDLERS.<computed> (http://localhost:7357/assets/vendor.js:46819:11)
           at raiseOnDeprecation (http://localhost:7357/assets/vendor.js:46752:11)
           at HANDLERS.<computed> (http://localhost:7357/assets/vendor.js:46819:11)
           at invoke (http://localhost:7357/assets/vendor.js:46831:11)
           at deprecate (http://localhost:7357/assets/vendor.js:46790:30)
           at Object.get [as $] (http://localhost:7357/assets/vendor.js:66640:52)
           at _setupAJAXHooks (http://localhost:7357/assets/test-support.js:9732:11)
           at _class.setupAJAXListeners (http://localhost:7357/assets/test-support.js:12924:38)

I tracked down the issue in ember-test-helpers (See emberjs/ember-test-helpers#546), released in 1.3.1.

ember-qunit updated its version of ember-test-helpers in 4.3.0 (See emberjs/ember-qunit#434)

ember-cli-qunit is deprecated in favor of ember-qunit.

@cyril-sf cyril-sf mentioned this pull request Apr 25, 2019
Merged
[CHORE] Replace deprecated ember-cli-qunit with ember-qunit
a90d5fe 
`ember-test-helpers` is generating too many deprecations leading Travis
to not be able to read the result of the tests.

`ember-test-helpers` was used by `ember-cli-qunit` but
`ember-cli-qunit` is now deprecated on favor to `ember-qunit`.
@cyril-sf cyril-sf force-pushed the chore/update-ember-test-helpers branch 2 times, most recently from b0fc3e6 to a90d5fe Compare April 26, 2019 20:15
@cyril-sf
Copy link
Contributor Author

cyril-sf commented Apr 26, 2019 •
edited
Loading

I can't reproduce the failures locally, so I don't know how to start with this at the moment.

@RobbieTheWagner
Copy link
Member

This same work was done here #280

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
duplicate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cyril-sf @RobbieTheWagner