Update ember-cli-sass #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Failing tests are the known sustain bugs and some tests fixed in #99 I went through the addon rabbit hole to see if there are any breaking changes and found none. |
kybishop
approved these changes
Dec 27, 2016
kybishop
requested changes
Dec 27, 2016
package.json
Outdated
| "ember-cli-htmlbars": "^1.0.3", | ||
| "ember-cli-preprocess-registry": "^3.0.0", | ||
| "ember-cli-sass": "^5.3.1", | ||
| "ember-cli-sass": "6.0.0", |
Collaborator
There was a problem hiding this comment.
Shouldn't this also get a caret to pin it to 6.x.x?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having flexi with ember-cli-sass 5.x and using 6.x in my apps and addons was causing things to break. I propose we update to 6.0.0, and release it as part of the major breaking update we will have when we split everything out.