Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use python 3.8 in CI builds #820

Merged
merged 11 commits into from
Feb 20, 2021
Merged

Use python 3.8 in CI builds #820

merged 11 commits into from
Feb 20, 2021

Conversation

breznak
Copy link
Member

@breznak breznak commented Jun 2, 2020

All PRs CI use py3.8, for releases we provide 3.7, 3.8.

Fixes #734 #809

@breznak breznak added ready tooling python not py binding, but merge py code in repo labels Jun 2, 2020
@breznak breznak self-assigned this Jun 2, 2020
@breznak breznak requested a review from dkeeney June 2, 2020 13:57
@breznak
Copy link
Member Author

breznak commented Jun 2, 2020

linux py3.8 tests fail,
https://github.com/htm-community/htm.core/pull/820/checks?check_run_id=731129639#step:9:1053

strangely, I cannot replicate that locally on 20.04.

in order to try debug py3.8 test failures.
@breznak
Copy link
Member Author

breznak commented Jun 2, 2020

I don't know why tests would start failing to import on Py3.8

@breznak breznak changed the title Check python 3.8 in CI builds Use python 3.8 in CI builds Feb 19, 2021
Copy link
Member Author

@breznak breznak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dkeeney this is now passing, please review Py3.8 support.

Copy link

@dkeeney dkeeney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I understand what the change is. I centers the expected result better within the 0.003 allowance.
Did you confirm it did not break 3.7?

@breznak
Copy link
Member Author

breznak commented Feb 19, 2021

centers the expected result better within the 0.003 allowance.

this is just a fix for the prev merged PR for RDSE params_check(), which has random behavior - and on OSX I randomly failed the assert. As adviced, I increased the SDR size (so conflicts are more rare) and that changed the results.

Did you confirm it did not break 3.7?

The test didn't. But now we fully test only on py3.8. Do we want to keep some platform on 3.7 to cover both? Good idea.

@dkeeney
Copy link

dkeeney commented Feb 19, 2021

Will, even if you manually checked it with 3.7 it would be ok.

@breznak breznak merged commit fc5407f into master Feb 20, 2021
@breznak breznak deleted the py38 branch February 20, 2021 11:43
@breznak
Copy link
Member Author

breznak commented Feb 20, 2021

Do we want to keep some platform on 3.7 to cover both?

@dkeeney merged as is now, so we run everything on py3.8, do we want to keep, say OSX on 3.7?

@dkeeney
Copy link

dkeeney commented Feb 20, 2021

I think it should be sufficient if we manually check 3.7 locally before we check it in. We should only need to do that for a short while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python not py binding, but merge py code in repo ready tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to install numpy from source on Python 3.8
2 participants