-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use python 3.8 in CI builds #820
Conversation
with py3.7 on other OSes
linux py3.8 tests fail, strangely, I cannot replicate that locally on 20.04. |
in order to try debug py3.8 test failures.
not 3.8
I don't know why tests would start failing to import on Py3.8 |
had to increase SDR size (to pass sanity check) so the result slightly changed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dkeeney this is now passing, please review Py3.8 support.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I understand what the change is. I centers the expected result better within the 0.003 allowance.
Did you confirm it did not break 3.7?
this is just a fix for the prev merged PR for RDSE params_check(), which has random behavior - and on OSX I randomly failed the assert. As adviced, I increased the SDR size (so conflicts are more rare) and that changed the results.
The test didn't. But now we fully test only on py3.8. Do we want to keep some platform on 3.7 to cover both? Good idea. |
Will, even if you manually checked it with 3.7 it would be ok. |
@dkeeney merged as is now, so we run everything on py3.8, do we want to keep, say OSX on 3.7? |
I think it should be sufficient if we manually check 3.7 locally before we check it in. We should only need to do that for a short while. |
All PRs CI use py3.8, for releases we provide 3.7, 3.8.
Fixes #734 #809