math/Utils: removed, removes support for I/O BigEndian files #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- we do not support any BigEndian platforms, that code has not been run or tested - otherwise, math/Utils had no usage, so can be removed
breznak
added
ready
code
|
@dkeeney you should probably review this, as you made the capnp switch and work on NetworkAPI. |
breznak
commented
Mar 5, 2019
| @@ -29,7 +29,6 @@ | |||
| #include <cstdio> //fopen | |||
| #include <iostream> | |||
| #include <math.h> | |||
| #include <nupic/math/Utils.hpp> // For isSystemLittleEndian and utils::swapBytesInPlace. | |||
There was a problem hiding this comment.
these were the only uses of math/Utils,
and I could remove the support (for reading files with different endian-ness, as we can only serialize to/from files on the same platform now)
|
See also issue #175. |
The code is actually rather ugly and there is no reason that it needs to be that way. But it works and I think it is a lower priority to clean up that code. Perhaps a cleanup would be appropriate if/when we change the name as per Issue #306. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
or tested
Fixes #103
For #306 VectorFile: removes BigEndian support
API breakage: VectorFileSensor can no longer Read files created on BigEndian on a LittleEnd platform, but since we revamped Serialization completely by removing capnp, this is not an issue. As now we support serialization only on the same platform as the code runs.