Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove_buffer #196

Merged
merged 1 commit into from
Jan 5, 2019
Merged

remove_buffer #196

merged 1 commit into from
Jan 5, 2019

Conversation

dkeeney
Copy link

@dkeeney dkeeney commented Jan 5, 2019

This removes Buffer and ObjectModel classes which were left-overs from a previous version of nupic. Basically this is removing code rot. These two classes were used for getters/setters on regions in the Network framework. There were replaced with getParameter( ) and setParameter( ) long ago but the Buffer and ObjectModel code was left in place to catch older implementations of nupic regions that had not been converted. TestNode and VectorFileSensor were the only ones of that type and I fixed those.

…left-overs from a previous version of nupic.
Copy link
Collaborator

@ctrl-z-9000-times ctrl-z-9000-times left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

@dkeeney
Copy link
Author

dkeeney commented Jan 5, 2019

Thanks @ctrl-z-9000-times

@dkeeney dkeeney merged commit 9c9e130 into master Jan 5, 2019
@dkeeney dkeeney deleted the remove_buffer branch January 5, 2019 19:21
Copy link
Member

@breznak breznak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see this go 👍 Thanks @dkeeney

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants