Adds support for remote serial ports. #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe this is also an alternative to #5 |
|
looks good so far ... could you please add a note in the README to make this new feature visible |
|
I removed the unused import and added documentation. Hopefully it is clear to understand. It would be great, if you update your homeassistant component as well :-) |
|
Just published a new version (0.4) of the lib. Don't know when I have the time to update it in homeassistant. Maybe you're interested in doing that? Please feel free. |
|
Done with PR: home-assistant/core#26088 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, it would be great to have remote serial ports also included in this library. With this PR i added a factory that checks the prefix of the port property. If the port starts with "rfc2217://" it will use the RFC2217 implementation of serial else the serial port implementation. I have testet this with ser2net and the following config line:
2000:telnet:0:/dev/ttyS0:9600 remctl bannerYou can then run the following command from the client command line:
pylacrosse -d rfc2217://192.168.0.1:20001 scanI am not a python developer. Feel free to change this code :-)