Install PHP 5.6.12 with tidy-html5

[skynet]

Back to square one:

checking for TIDY support... yes
configure: error: Cannot find libtidy

I wonder if anyone else was able to install php with this library. I was able to but in the past. Not with 5.0.0.RC1 though.

[skynet]

And if I configure php with --with-tidy=/usr/local I get this:

/usr/local/src/php-5.6.12/ext/tidy/tidy.c:34:20: fatal error: buffio.h: No such file or directory
 #include "buffio.h"
                    ^
compilation terminated.
make: *** [ext/tidy/tidy.lo] Error 1
/bin/sh /usr/local/src/php-5.6.12/libtool --silent --preserve-dup-deps --mode=compile cc  -Iext/tidy/ -I/usr/local/src/php-5.6.12/ext/tidy/ -DPHP_ATOM_INC -I/usr/local/src/php-5.6.12/include -I/usr/local/src/php-5.6.12/main -I/usr/local/src/php-5.6.12 -I/usr/local/src/php-5.6.12/ext/date/lib -I/usr/local/src/php-5.6.12/ext/ereg/regex -I/usr/include/libxml2 -I/usr/X11 -I/usr/include/freetype2 -I/usr/local/imap-2007f/include -I/usr/local/src/php-5.6.12/ext/mbstring/oniguruma -I/usr/local/src/php-5.6.12/ext/mbstring/libmbfl -I/usr/local/src/php-5.6.12/ext/mbstring/libmbfl/mbfl -I/usr/local/src/php-5.6.12/ext/sqlite3/libsqlite -I/usr/include/pspell -I/usr/local/include -I/usr/local/src/php-5.6.12/TSRM -I/usr/local/src/php-5.6.12/Zend    -I/usr/include -g -O2 -fvisibility=hidden  -c /usr/local/src/php-5.6.12/ext/tidy/tidy.c -o ext/tidy/tidy.lo
/usr/local/src/php-5.6.12/ext/tidy/tidy.c:34:20: fatal error: buffio.h: No such file or directory
 #include "buffio.h"
                    ^
compilation terminated.
make: *** [ext/tidy/tidy.lo] Error 1
/bin/sh /usr/local/src/php-5.6.12/libtool --silent --preserve-dup-deps --mode=compile cc  -Iext/tidy/ -I/usr/local/src/php-5.6.12/ext/tidy/ -DPHP_ATOM_INC -I/usr/local/src/php-5.6.12/include -I/usr/local/src/php-5.6.12/main -I/usr/local/src/php-5.6.12 -I/usr/local/src/php-5.6.12/ext/date/lib -I/usr/local/src/php-5.6.12/ext/ereg/regex -I/usr/include/libxml2 -I/usr/X11 -I/usr/include/freetype2 -I/usr/local/imap-2007f/include -I/usr/local/src/php-5.6.12/ext/mbstring/oniguruma -I/usr/local/src/php-5.6.12/ext/mbstring/libmbfl -I/usr/local/src/php-5.6.12/ext/mbstring/libmbfl/mbfl -I/usr/local/src/php-5.6.12/ext/sqlite3/libsqlite -I/usr/include/pspell -I/usr/local/include -I/usr/local/src/php-5.6.12/TSRM -I/usr/local/src/php-5.6.12/Zend    -I/usr/include -g -O2 -fvisibility=hidden  -c /usr/local/src/php-5.6.12/ext/tidy/tidy.c -o ext/tidy/tidy.lo
/usr/local/src/php-5.6.12/ext/tidy/tidy.c:34:20: fatal error: buffio.h: No such file or directory
 #include "buffio.h"
                    ^
compilation terminated.
make: *** [ext/tidy/tidy.lo] Error 1

[geoffmcl]

@skynet, yes, two header file names have been changed - See Major API change - #224, #223, #221

Commit 1e70fc6

This means in the PHP source, "buffio.h" needs to be changed to "tidybuffio.h" in the file ext/tidy/tidy.c, and anywhere else "buffio.h" is used...

And if the tidy "platform.h" old header is included anywhere in the PHP source, it must be changed to "tidyplatform.h"...

And all should be well compiling PHP ;=))

It is also a good idea to check /usr/include and /usr/local/include and delete any old instances of "buffio.h" and "platform.h", just to be sure...

And this would be a good time to remind the PHP maintenance people that the API tidyReleaseDate() is deprecated, and they should use tidyLibraryVersion() instead... see lines 1105 and 1360 of that same ext/tidy/tidy.c file... and maybe else where...

Also note --with-tidy=/usr/local will only be the default Tidy 5.0.0 install location if you do not add the option -DCMAKE_INSTALL_PREFIX=/usr when building, installing Tidy! from source...

Further, if you want to install a Release version of Tidy! - that is one free of the assert macro - then you should also add the option -DCMAKE_BUILD_TYPE=Release when building and installing from source...

Hope this gets things ticking ;=))

[skynet]

@geoffmcl - we need to provide a patch, instead of asking people to do this manually. Can you come up with something?

[skynet]

In fact it is a simple as doing this in the php source directory:

sed -i 's/buffio.h/tidybuffio.h/' ext/tidy/*.c

[geoffmcl]

@skynet, as I suggested above I was poking around looking for old tidy headers to delete, and just checked in /usr/lib!

$ cd /usr/lib
$ ls -l *tidy*

And WOW, what a lot of crud I found ;=((

lrwxrwxrwx 1 root root     21 Jul 23 19:30 libtidy-0.99.so.0 -> libtidy-0.99.so.0.0.0
-rw-r--r-- 1 root root 379384 Jul 23 19:30 libtidy-0.99.so.0.0.0
-rw-r--r-- 1 root root 836298 Jun  9 13:04 libtidy5s.a
lrwxrwxrwx 1 root root     13 Apr 15 17:11 libtidy5.so -> libtidy5.so.4
lrwxrwxrwx 1 root root     18 Jun  9 13:05 libtidy5.so.4 -> libtidy5.so.4.9.35
-rw-r--r-- 1 root root 649706 May 24 15:25 libtidy5.so.4.9.30
-rw-r--r-- 1 root root 649706 Jun  3 20:32 libtidy5.so.4.9.31
-rw-r--r-- 1 root root 649706 Jun  4 18:07 libtidy5.so.4.9.32
-rw-r--r-- 1 root root 649706 Jun  6 13:16 libtidy5.so.4.9.33
-rw-r--r-- 1 root root 649706 Jun  8 14:00 libtidy5.so.4.9.34
-rw-r--r-- 1 root root 649706 Jun  9 13:04 libtidy5.so.4.9.35
-rw-r--r-- 1 root root 545232 Jul 23 19:30 libtidy.a
-rw-r--r-- 1 root root    950 Jul 23 19:30 libtidy.la
-rw-r--r-- 1 root root 838296 Aug 15 11:10 libtidys.a
lrwxrwxrwx 1 root root     12 Aug 15 11:11 libtidy.so -> libtidy.so.5
lrwxrwxrwx 1 root root     18 Jun  9 13:07 libtidy.so.4 -> libtidy5.so.4.9.35
lrwxrwxrwx 1 root root     16 Aug 15 11:11 libtidy.so.5 -> libtidy.so.5.1.5
-rw-r--r-- 1 root root 649741 Jul  1 11:58 libtidy.so.5.0.0
-rw-r--r-- 1 root root 649706 Jun 23 16:03 libtidy.so.5.0.1
-rw-r--r-- 1 root root 649824 Jul 13 13:07 libtidy.so.5.1.1
-rw-r--r-- 1 root root 649954 Aug 15 11:10 libtidy.so.5.1.5

I pruned that down to just four(4) -

-rw-r--r-- 1 root root 838296 Aug 15 11:10 libtidys.a
lrwxrwxrwx 1 root root     12 Aug 15 11:11 libtidy.so -> libtidy.so.5
lrwxrwxrwx 1 root root     16 Aug 15 11:11 libtidy.so.5 -> libtidy.so.5.1.5
-rw-r--r-- 1 root root 649954 Aug 15 11:10 libtidy.so.5.1.5

This is actually the version built by the current issue-228 branch...

$ tidy -v
HTML Tidy for Linux version 5.1.5.D231

What would be great if an install cleaned up the old libraries, but I do not know how to do that!

Any ideas welcome...

[skynet]

I always install it on a clean system, not on top of the very old one.

cd /usr/local/lib
ls -l | grep tidy

-rw-r--r--  1 root root 818522 Aug 11 18:11 libtidys.a
lrwxrwxrwx  1 root root     12 Aug 11 18:11 libtidy.so -> libtidy.so.5
lrwxrwxrwx  1 root root     16 Aug 11 18:11 libtidy.so.5 -> libtidy.so.5.0.0
-rwxr-xr-x  1 root root 696520 Aug 11 18:11 libtidy.so.5.0.0

Cleaning up could be done manually if one knows what old tidy libraries can be removed. More important to me is to make it possible for every one to be able to use the library with other builds (php for example).

[nuxwin]

@geoffmcl

Description: ftbfs - buffio.h renamed to tinybuffio.h in tidy-html5
Author: Laurent Declercq <l.declercq@nuxwin.com>
---
This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
--- a/ext/tidy/config.m4
+++ b/ext/tidy/config.m4
@@ -27,6 +27,12 @@ if test "$PHP_TIDY" != "no"; then
     AC_MSG_ERROR(Cannot find libtidy)
   fi

+  if test -r "$TIDY_INCDIR/tidybuffio.h"; then
+    PHP_TIDY_BUFFIO_H_PATH="$TIDY_INCDIR/tidybuffio.h"
+  else
+    PHP_TIDY_BUFFIO_H_PATH="$TIDY_INCDIR/buffio.h"
+  fi
+
   TIDY_LIBDIR=$TIDY_DIR/$PHP_LIBDIR

   PHP_ADD_LIBRARY_WITH_PATH(tidy, $TIDY_LIBDIR, TIDY_SHARED_LIBADD)
@@ -37,8 +43,20 @@ if test "$PHP_TIDY" != "no"; then
   AC_DEFINE(HAVE_TIDYOPTGETDOC,1,[ ])
   ],[],[])

+    AC_MSG_CHECKING([if your cpp allows macro usage in include lines])
+    AC_TRY_COMPILE([
+#define FOO <$PHP_TIDY_BUFFIO_H_PATH>
+#include FOO
+    ], [], [
+      AC_MSG_RESULT([yes])
+      PHP_DEFINE([PHP_TIDY_BUFFIO_H_PATH], [<$PHP_TIDY_BUFFIO_H_PATH>],[ext/tidy])
+      AC_DEFINE_UNQUOTED([PHP_TIDY_BUFFIO_H_PATH], [<$PHP_TIDY_BUFFIO_H_PATH>], [Path to buffio.h])
+    ], [
+      AC_MSG_RESULT([no])
+    ])

   PHP_NEW_EXTENSION(tidy, tidy.c, $ext_shared)
   PHP_SUBST(TIDY_SHARED_LIBADD)
+  PHP_INSTALL_HEADERS([ext/tidy/])
   AC_DEFINE(HAVE_TIDY,1,[ ])
 fi
--- a/ext/tidy/tidy.c
+++ b/ext/tidy/tidy.c
@@ -31,7 +31,12 @@
 #include "ext/standard/info.h"

 #include "tidy.h"
-#include "buffio.h"
+
+#ifdef PHP_TIDY_BUFFIO_H_PATH
+#include PHP_TIDY_BUFFIO_H_PATH
+#else
+#include <buffio.h>
+#endif

 /* compatibility with older versions of libtidy */
 #ifndef TIDY_CALL

made against PHP 5.6.23 ;)

[nuxwin]

@geoffmcl

Should I forward to upstream?

[garylab]

I install tidy in my docker container, the OS is alpine, so first I install tidyhtml-devand then create a soft link, full command is:

apk add --no-cache tidyhtml-dev
ln -s /usr/include/tidybuffio.h /usr/include/buffio.h
docker-php-ext-install tidy

It worked!