Fix cppfront incomplete type build error (fix #690) #691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe |
|
I was about to make it a global static, and fix the accessors to return |
|
@hsutter Yes, I took a second look and I was about to try an change all accessors. I'm ok with closing this ticket and let you do it or continue with your suggestion. Your call. |
* Change template_arguments() functions to return a const ref * Make the empty vector of args a const global
zaucy
pushed a commit
to zaucy/cppfront
that referenced
this pull request
Dec 5, 2023
* Fix cppfront incomplete type build error (fix hsutter#690) * Improve previous implementation * Change template_arguments() functions to return a const ref * Make the empty vector of args a const global
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm submitting an effort to fix the problem.
While it should work, the function
template_arguments()returns a non-const reference to a static object that should stay empty, yet it could potentially be populated by the caller of the function. I'm not entirely ok with this, but I haven't dug any deeper, could the reference be changed to point to a const object?UPDATE:
Upon @hsutter suggestion I changed the empty vector to be a const global. The
template_arguments()functions now return a const ref.Again, this was my attempt to fix this issue. Should a better implementation be provided, I'm ok with that.