fix(cpp1): support assignment from expression list #487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohelEGP
force-pushed
the
assign_expression_list
branch
from
2465e13 to
4dff91c
Compare
hsutter
reviewed
Aug 10, 2023
| // go through the whole grammar, and surround it with braces | ||
| if ( | ||
| x.op->type() == lexeme::Assignment | ||
| && x.expr->is_expression_list() |
There was a problem hiding this comment.
This looks good, but it needs
&& std::ssize(x.expr->get_expression_list()->expressions.size()) != 1
otherwise x = (move y); will grow braces we don't need. I'll make the change directly and merge.
Thanks!
There was a problem hiding this comment.
On second thought, I was wrong -- we want those { } in other cases. Will revert my changes...
Added size check so we don't add `{` `}` around single-element lists
Signed-off-by: Herb Sutter <herb.sutter@gmail.com>
`std::ssize` for consistency, and `!= 1` so we still emit `{` `}` around empty lists.
Signed-off-by: Herb Sutter <herb.sutter@gmail.com>
Signed-off-by: Herb Sutter <herb.sutter@gmail.com>
|
Thanks! |
zaucy
pushed a commit
to zaucy/cppfront
that referenced
this pull request
Dec 5, 2023
* fix(cpp1): support assignment from expression list
* Update cppfront.cpp
Added size check so we don't add `{` `}` around single-element lists
Signed-off-by: Herb Sutter <herb.sutter@gmail.com>
* Update cppfront.cpp
`std::ssize` for consistency, and `!= 1` so we still emit `{` `}` around empty lists.
Signed-off-by: Herb Sutter <herb.sutter@gmail.com>
* Update cppfront.cpp
Signed-off-by: Herb Sutter <herb.sutter@gmail.com>
---------
Signed-off-by: Herb Sutter <herb.sutter@gmail.com>
Co-authored-by: Herb Sutter <herb.sutter@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #321.
Resolves #449.
Now fixing #408 becomes necessary.
The reason is explained at #451 (comment):
Testing summary.
Acknowledgements.