First line splits by \t and space too.#9
Merged
hsorby merged 9 commits intohsorby:mainfrom Nov 13, 2025
Merged
Conversation
Updated section splitting method to use regex for better handling of whitespace. My first line of my .trc had a space for the last col: ```bash PathFileType 4 (X/Y/Z) abd_0kg_1.trc ``
hsorby
reviewed
Nov 12, 2025
Owner
hsorby
left a comment
hsorby
left a comment
There was a problem hiding this comment.
Please add a test for this change, that would be really helpful to make sure we don’t regress this new behaviour.
Add installation instructions for the TRC data reader package.
Contributor
Author
Done. |
Contributor
Author
|
I took the liberty to modify the readme format. It's easier to copy-paste code from it when well declared in a .md file. |
hsorby
requested changes
Nov 13, 2025
Owner
hsorby
left a comment
hsorby
left a comment
There was a problem hiding this comment.
You need to also change the entry in the pyproject.toml file for the readme.
Contributor
Author
|
done |
Owner
|
You need to resolve the conflict before this can be merged in. |
Contributor
Author
|
I hope it's enough for you :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated section splitting method to use regex for better handling of whitespace.
My first line of my .trc had a space for the last col:
If you want I can add supplementary test file.
Other than that, Everything worked fine great job !