Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor names and arguments #121

Merged
merged 30 commits into from
May 1, 2024
Merged

Refactor names and arguments #121

merged 30 commits into from
May 1, 2024

Conversation

hsloot
Copy link
Owner

@hsloot hsloot commented Apr 25, 2024

Related issues

None

Checklist

  • R CMD CHECK successful
  • Tests included
  • Documentation included or updated
  • Commit messages follow commit guidelines

Optional, but recommended:

  • Code passes lintr::lint_package() without errors

Description

Proposed changes:

  • Rename S4-method exIntensities() to calcExShockSizeArrivalIntensities() and arguments/variables ex_intensities to theta
  • Rename S4-method uexIntensities() to calcExShockArrivalIntensities()
  • Rename S4-method exQMatrix() to calcMDCMGeneratorMatrix()
  • Rename S4-method intensities() to calcShockArrivalIntensities()
  • Rename S4-method defaultMethod() to getDefaultMethodString()
  • Rename S4-method levyDensity() to getLevyDensity()
  • Rename S4-method stieltjesDensity() to getStieltjesDensity()
  • Rename S4-method valueOf() to calcIterativeDifference()
  • Rename S4-method valueOf0() to calcValue()

@hsloot hsloot added the Refactor Improve some code by rewriting it label Apr 25, 2024
@hsloot hsloot self-assigned this Apr 25, 2024
@hsloot hsloot force-pushed the refactor/rename-s4-methods branch from d8eba44 to 632f711 Compare April 25, 2024 20:28
Copy link

codecov bot commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 64.77273% with 31 lines in your changes are missing coverage. Please review.

Project coverage is 93.49%. Comparing base (188b25a) to head (1c03c8d).
Report is 25 commits behind head on main.

❗ Current head 1c03c8d differs from pull request most recent head fd74c95. Consider uploading reports for the commit fd74c95 to get more accurate results

Files Patch % Lines
R/rmo-deprecated.R 0.00% 29 Missing ⚠️
R/s4-LevyBernsteinFunction.R 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
- Coverage   95.85%   93.49%   -2.36%     
==========================================
  Files          55       56       +1     
  Lines        1399     1446      +47     
==========================================
+ Hits         1341     1352      +11     
- Misses         58       94      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner Author

@hsloot hsloot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@hsloot hsloot marked this pull request as ready for review April 30, 2024 23:38
Copy link
Owner Author

@hsloot hsloot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@hsloot hsloot merged commit 909d9db into main May 1, 2024
8 of 10 checks passed
@hsloot hsloot deleted the refactor/rename-s4-methods branch May 1, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor Improve some code by rewriting it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant