Make crate no_std compatible #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use BTreeSet instead of HashSet in test, so that test can run on no_std - Replace all imports of Vec and String with respective alloc types - use core instead of std
|
If this gets merged, please publish a new version so I can merge the other PR, thanks |
hsivonen
requested changes
Feb 4, 2021
|
I've published a new version with this change to crates.io. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no_stdVecandStringwith respectivealloctypesuse core::instead ofuse std::This is a preparation for yeslogic/allsorts#42, it would be nice if this could get merged so that we can have a proper font shaping library on
no_std.