enh: update Python version to 3.12 and refine notebook content#89
Merged
jonas-eschle merged 4 commits intomasterfrom Jun 19, 2025
Merged
enh: update Python version to 3.12 and refine notebook content#89jonas-eschle merged 4 commits intomasterfrom
jonas-eschle merged 4 commits intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the lesson environment to Python 3.12, reorganizes tutorial indices, and enriches the Advanced Classes notebook with decorator and naming-conventions content.
- Updated
environment.ymlto Python 3.12 and movedzfitpackages into main dependencies - Reordered files in
python/README.mdand standardized notebook header levels - Expanded
12AdvancedClasses.ipynbwith sections on decorators, naming rules, and refined dunder explanations
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| python/README.md | Reordered operators.md, removed scripting.md from the TOC |
| python/01basics.ipynb | Changed # Jupyter to ## Jupyter for consistent heading levels |
| environment.yml | Bumped Python to ~=3.12.0, added zfit & zfit-physics |
| advanced-python/12AdvancedClasses.ipynb | Added decorators overview, naming conventions, and updated dunder examples |
Comments suppressed due to low confidence (1)
python/README.md:55
- You’ve removed
scripting.mdfrom the index. Make sure the file itself is deleted (if obsolete) or update any links elsewhere to prevent broken references.
methods.md
| " scores = [self.homework_avg, self.exam_avg]\n", | ||
| " if self.extra_credit is not None:\n", | ||
| " scores.append(self.extra_credit)\n", | ||
| " return 4.0 * self.avg(scores)/100." |
There was a problem hiding this comment.
The hard-coded divisor 100 (and multiplier 4.0) is a magic number. Consider extracting these into named constants or documenting the scaling logic for clarity.
Suggested change
| " return 4.0 * self.avg(scores)/100." | |
| " return self.GPA_SCALE * self.avg(scores)/self.PERCENTAGE_DIVISOR" |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.