Skip to content

enh: update Python version to 3.12 and refine notebook content#89

Merged
jonas-eschle merged 4 commits intomasterfrom
upgrade_deps_notebooks
Jun 19, 2025
Merged

enh: update Python version to 3.12 and refine notebook content#89
jonas-eschle merged 4 commits intomasterfrom
upgrade_deps_notebooks

Conversation

@jonas-eschle
Copy link
Collaborator

No description provided.

@jonas-eschle jonas-eschle enabled auto-merge June 18, 2025 18:09
@jonas-eschle jonas-eschle requested a review from Copilot June 18, 2025 18:09
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the lesson environment to Python 3.12, reorganizes tutorial indices, and enriches the Advanced Classes notebook with decorator and naming-conventions content.

  • Updated environment.yml to Python 3.12 and moved zfit packages into main dependencies
  • Reordered files in python/README.md and standardized notebook header levels
  • Expanded 12AdvancedClasses.ipynb with sections on decorators, naming rules, and refined dunder explanations

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
python/README.md Reordered operators.md, removed scripting.md from the TOC
python/01basics.ipynb Changed # Jupyter to ## Jupyter for consistent heading levels
environment.yml Bumped Python to ~=3.12.0, added zfit & zfit-physics
advanced-python/12AdvancedClasses.ipynb Added decorators overview, naming conventions, and updated dunder examples
Comments suppressed due to low confidence (1)

python/README.md:55

  • You’ve removed scripting.md from the index. Make sure the file itself is deleted (if obsolete) or update any links elsewhere to prevent broken references.
    methods.md

" scores = [self.homework_avg, self.exam_avg]\n",
" if self.extra_credit is not None:\n",
" scores.append(self.extra_credit)\n",
" return 4.0 * self.avg(scores)/100."
Copy link

Copilot AI Jun 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hard-coded divisor 100 (and multiplier 4.0) is a magic number. Consider extracting these into named constants or documenting the scaling logic for clarity.

Suggested change
" return 4.0 * self.avg(scores)/100."
" return self.GPA_SCALE * self.avg(scores)/self.PERCENTAGE_DIVISOR"

Copilot uses AI. Check for mistakes.
jonas-eschle and others added 2 commits June 19, 2025 08:50
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@jonas-eschle jonas-eschle disabled auto-merge June 19, 2025 06:51
@jonas-eschle jonas-eschle merged commit 3731c8b into master Jun 19, 2025
0 of 2 checks passed
@jonas-eschle jonas-eschle deleted the upgrade_deps_notebooks branch June 19, 2025 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant