-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Create AppImage on CI #20464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create AppImage on CI #20464
Conversation
|
nice! |
|
Btw, i didn't see macOS build released for v1.19 at https://github.com/hrydgard/ppsspp/releases Did the build.yml didn't get triggered when the v1.19 tag created? 🤔 |
|
Also, should i use PPSSPP or PPSSPPSDL on the name? 🤔 |
|
Go for PPSSPP I guess. been meaning to change PPSSPPSDL to PPSSPP for some time, haven't gotten around to it. |
|
@anr2me Note that for deltas to work, the In other words the artifact names cannot change between being made and being released. |
Hmm.. i guess we need to change the script to fix the naming🤔 should i add an argument for the script to use it as version, and fallback to "test" when without any argument? or it's as simple as exporting VERSION var before running the script? So the "test" part can be replaced with the tag, right? |
Can be anything, what is important is that the filename does not change after the And maybe a check to make sure the var isn't empty would be good as well. |
i was thinking using this Since we use a short hash following the version number on artifacts without release, but only the version number on release, we probably need to adjust the version outside of the script (depends on the trigger) |
Ye that works. |
|
In any case you can also just remove It is not recommended by the appimage spec but it is not mandated either. |
|
Hmm.. it seems the file size is slightly smaller with |
|
Btw @Samueru-sama , i tried using clang on the archlinux image you use for PPSSPP-AppImage repo, but doing a simple |
The smaller llvm doesn't have powerpc targets. clang by default tests building for powerpc and a bunch of other arches, so you ran into that issue. One way to get around this issue is by installing the smaller llvm after building, but this is not guaranteed to work, I had this issue with dolphin-emu where for some reason it depends on all the llvm targets even on the compiled binary. For this I have |
|
Are we good to go here with the change as-is? I guess we can optimize the size later... (as for powerpc, we're probably never gonna support that anyway heh so it can go) |
|
Yeah, it's ready. I already changed it to RelWithDebInfo. The powerpc stuff is just an issue of clang, this workflow only generates x64 and arm64 AppImages |


Automatically create AppImage artifacts on commit push.
Automatically update released files on a new tag.
Example of released files: https://github.com/ANR2MERefork/ppsspp/releases
Thanks to @Samueru-sama
PS: I use
Releaseconfiguration instead ofRelWithDebInfo, not sure which one will be better🤔