Android: Improve mouse input #19915
Merged
Android: Improve mouse input #19915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrydgard
added
Platform-specific (Android)
Input/Controller
|
Testing on a more modern phone than the pocophone f1, I'm having issues with duplicate mouse button events. Both getting input from onGenericMotionEvent (MotionEvent.ACTION_BUTTON_PRESS) and from onTouchEvent on the surfaceview. While on the older phone I was only getting events from the surfaceview. However on ChromeOS and newer phones the former is what you should use. So will have to do some kind of version cutoff I guess... or, as soon as we see a "modern" event, we switch over. |
hrydgard
force-pushed
the
android-mouse-work
branch
2 times, most recently
from
39f215d to
ab36dec
Compare
|
OK, now I have the full feature set working on a phone supporting all the modern stuff. Now just gotta go back and check that things are not crazy on an older one, before I merge... |
Use the new modern events like HOVER.
…th broken mouse support like Poco F1
hrydgard
force-pushed
the
android-mouse-work
branch
from
ab36dec to
725f72a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mouse on Android is really wacky unfortunately.. but with this, it mostly works on my pocophone f1, buttons are mappable separately. And also on my Galaxy S21. On the pocophone, the right mouse button starts working after a few clicks...
Fixes #19186
Fixes the mouse problem in #19862 .
Adds touch support to ImGui on Android.