Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error compiling with GCC-5.4 #9178

Closed
latot opened this issue Dec 21, 2016 · 10 comments
Closed

Error compiling with GCC-5.4 #9178

latot opened this issue Dec 21, 2016 · 10 comments

Comments

@latot
Copy link
Contributor

latot commented Dec 21, 2016

Hi, as the title says, i can't compile ppsspp with gcc-5.4:

In file included from /home/pipe/Documentos/git/ppsspp/ext/glslang/glslang/MachineIndependent/../Include/InfoSink.h:39:0,
                 from /home/pipe/Documentos/git/ppsspp/ext/glslang/glslang/MachineIndependent/intermOut.cpp:38:
/home/pipe/Documentos/git/ppsspp/ext/glslang/glslang/MachineIndependent/intermOut.cpp: En la función ‘bool {anónimo}::is_positive_infinity(double)’:
/home/pipe/Documentos/git/ppsspp/ext/glslang/glslang/MachineIndependent/intermOut.cpp:52:15: error: expected unqualified-id before ‘(’ token
   return std::isinf(x) && (x >= 0);

I use Gentoo 64.

Thx. Cya.

@hrydgard
Copy link
Owner

another glslang bug? you've properly updated your submodules, right? if not it should be enough to rm -rf ext/glslang and then git submodule init --update --recursive.

Since we are now using upstream glslang, this should really be reported at https://github.com/KhronosGroup/glslang if it's still an issue.

@latot
Copy link
Contributor Author

latot commented Dec 21, 2016

okis, i have the submodules updated, seems you have a little of experience with gslang bugs..

Linking!

KhronosGroup/glslang#642

Thx. Cya.

@Orphis
Copy link
Collaborator

Orphis commented Dec 21, 2016

@hrydgard Actually, git submodule sync --recursive and then git submodule init --update --recursive are the proper commands!

@latot
Copy link
Contributor Author

latot commented Dec 21, 2016

in my case i use git submodule update --recursive

@mrcmunir
Copy link
Contributor

mrcmunir commented Dec 29, 2016

@latot Add #include < cmath > in that file I compile fine with GCC5.4 compiler

Edit : In the actual submodule it's ok code maybbe you bad Sync?

@latot
Copy link
Contributor Author

latot commented Dec 29, 2016

submodules are ok, reseted, rysync, etc...., and nice, that fix the issue!, updating upstream

@latot
Copy link
Contributor Author

latot commented Dec 29, 2016

Hi, this issue is already fixed in upstream, @hrydgard is possible update gslang branch of ppsspp with upstream?, or just fix this?

in the last case is only change math.c to cmath

Thx. Cya

@hrydgard
Copy link
Owner

Right, I'll update it. Thanks!

hrydgard added a commit that referenced this issue Dec 29, 2016
@hrydgard
Copy link
Owner

Done! Please reopen if there are still issues.

@latot
Copy link
Contributor Author

latot commented Dec 29, 2016

Hi!, now works, Thx!

pal1000 pushed a commit to pal1000/ppsspp that referenced this issue Jan 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants