Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On nvim-treesitter
main
, some of the methods used in cmp'scompare.scopes
now error instead of returning an empty table when no tree-sitter parser exists (specifically,locals.get_*
). This implements a basic fix.Leaving it as a draft because:compare.scopes
instead ofvim.b
?pcall
the affectedlocals.get_*
methods?Edit: This PR has also turned into an overhaul of
compare.scopes
:definitions
once perupdate()
update
, leading to more expected sorting (previously, nothing ever got removed or modified once it was put into thescopes_map
).edit2: I can also revert the renaming of the variables if you'd like, I just did it out of my preference when I was changing the function around