Fix URLs with quot; characters

Fixes woocommerce#10795
hrosb · Apr 27, 2016 · 020b8c9 · 020b8c9
1 parent a42e0bd
commit 020b8c9
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/includes/widgets/class-wc-widget-layered-nav.php b/includes/widgets/class-wc-widget-layered-nav.php
@@ -276,9 +276,12 @@ protected function get_page_base_url( $taxonomy ) {
 			$link = add_query_arg( 'orderby', wc_clean( $_GET['orderby'] ), $link );
 		}
 
-		// Search Arg
+		/**
+		 * Search Arg.
+		 * To support quote characters, first they are decoded from &quot; entities, then URL encoded.
+		 */
 		if ( get_search_query() ) {
-			$link = add_query_arg( 's', get_search_query(), $link );
+			$link = add_query_arg( 's', rawurlencode( htmlspecialchars_decode( get_search_query() ) ), $link );
 		}
 
 		// Post Type Arg

diff --git a/includes/widgets/class-wc-widget-rating-filter.php b/includes/widgets/class-wc-widget-rating-filter.php
@@ -61,9 +61,12 @@ protected function get_page_base_url() {
 			$link = add_query_arg( 'orderby', wc_clean( $_GET['orderby'] ), $link );
 		}
 
-		// Search Arg
+		/**
+		 * Search Arg.
+		 * To support quote characters, first they are decoded from &quot; entities, then URL encoded.
+		 */
 		if ( get_search_query() ) {
-			$link = add_query_arg( 's', get_search_query(), $link );
+			$link = add_query_arg( 's', rawurlencode( htmlspecialchars_decode( get_search_query() ) ), $link );
 		}
 
 		// Post Type Arg