hrchen · James-Chi-Jie · Oct 10, 2015 · Oct 10, 2015
diff --git a/NSThreadExample/.DS_Store b/NSThreadExample/.DS_Store
diff --git a/NSThreadExample/NSThreadExample.xcodeproj/project.pbxproj b/NSThreadExample/NSThreadExample.xcodeproj/project.pbxproj
@@ -214,7 +214,7 @@
 			isa = PBXProject;
 			attributes = {
 				CLASSPREFIX = PT;
-				LastUpgradeCheck = 0500;
+				LastUpgradeCheck = 0700;
 				ORGANIZATIONNAME = KiloApp;
 				TargetAttributes = {
 					F48BF748177045A10082371C = {
@@ -331,6 +331,7 @@
 				CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
 				"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer";
 				COPY_PHASE_STRIP = NO;
+				ENABLE_TESTABILITY = YES;
 				GCC_C_LANGUAGE_STANDARD = gnu99;
 				GCC_DYNAMIC_NO_PIC = NO;
 				GCC_OPTIMIZATION_LEVEL = 0;
@@ -392,6 +393,7 @@
 				GCC_PREFIX_HEADER = "NSThreadExample/NSThreadExample-Prefix.pch";
 				INFOPLIST_FILE = "NSThreadExample/NSThreadExample-Info.plist";
 				IPHONEOS_DEPLOYMENT_TARGET = 4.3;
+				PRODUCT_BUNDLE_IDENTIFIER = "com.kiloapp.${PRODUCT_NAME:rfc1034identifier}";
 				PRODUCT_NAME = "$(TARGET_NAME)";
 				WRAPPER_EXTENSION = app;
 			};
@@ -406,6 +408,7 @@
 				GCC_PREFIX_HEADER = "NSThreadExample/NSThreadExample-Prefix.pch";
 				INFOPLIST_FILE = "NSThreadExample/NSThreadExample-Info.plist";
 				IPHONEOS_DEPLOYMENT_TARGET = 4.3;
+				PRODUCT_BUNDLE_IDENTIFIER = "com.kiloapp.${PRODUCT_NAME:rfc1034identifier}";
 				PRODUCT_NAME = "$(TARGET_NAME)";
 				WRAPPER_EXTENSION = app;
 			};
@@ -427,6 +430,7 @@
 					"$(inherited)",
 				);
 				INFOPLIST_FILE = "NSThreadExampleTests/NSThreadExampleTests-Info.plist";
+				PRODUCT_BUNDLE_IDENTIFIER = "com.kiloapp.${PRODUCT_NAME:rfc1034identifier}";
 				PRODUCT_NAME = "$(TARGET_NAME)";
 				TEST_HOST = "$(BUNDLE_LOADER)";
 				WRAPPER_EXTENSION = xctest;
@@ -445,6 +449,7 @@
 				GCC_PRECOMPILE_PREFIX_HEADER = YES;
 				GCC_PREFIX_HEADER = "NSThreadExample/NSThreadExample-Prefix.pch";
 				INFOPLIST_FILE = "NSThreadExampleTests/NSThreadExampleTests-Info.plist";
+				PRODUCT_BUNDLE_IDENTIFIER = "com.kiloapp.${PRODUCT_NAME:rfc1034identifier}";
 				PRODUCT_NAME = "$(TARGET_NAME)";
 				TEST_HOST = "$(BUNDLE_LOADER)";
 				WRAPPER_EXTENSION = xctest;

diff --git a/NSThreadExample/NSThreadExample/NSThreadExample-Info.plist b/NSThreadExample/NSThreadExample/NSThreadExample-Info.plist
@@ -9,7 +9,7 @@
 	<key>CFBundleExecutable</key>
 	<string>${EXECUTABLE_NAME}</string>
 	<key>CFBundleIdentifier</key>
-	<string>com.kiloapp.${PRODUCT_NAME:rfc1034identifier}</string>
+	<string>$(PRODUCT_BUNDLE_IDENTIFIER)</string>
 	<key>CFBundleInfoDictionaryVersion</key>
 	<string>6.0</string>
 	<key>CFBundleName</key>

diff --git a/NSThreadExample/NSThreadExample/PTAppDelegate.m b/NSThreadExample/NSThreadExample/PTAppDelegate.m
@@ -17,6 +17,8 @@ void mainRunLoopObserver(CFRunLoopObserverRef observer, CFRunLoopActivity activi
     CFStringRef mode = CFRunLoopCopyCurrentMode(CFRunLoopGetMain());
     NSLog(@"Current main thread run loop mode: %@", (__bridge NSString *)mode);
 
+    CFRelease(mode);
+
     CFArrayRef modeArray = CFRunLoopCopyAllModes(CFRunLoopGetMain());
     if (CFArrayGetCount(modeArray) > 0)
     {
@@ -26,6 +28,8 @@ void mainRunLoopObserver(CFRunLoopObserverRef observer, CFRunLoopActivity activi
             NSLog(@"Main thread run loop has mode: %@", (__bridge NSString *)mode);
         }
     }
+
+    CFRelease(modeArray);
 }
 
 @interface PTAppDelegate()

diff --git a/NSThreadExample/NSThreadExample/PTCFRunLoopThread.m b/NSThreadExample/NSThreadExample/PTCFRunLoopThread.m
@@ -40,7 +40,7 @@ - (void)main
             {
                 [self cancel];
             }
-            NSLog(@"exit run loop.........: %ld", result);
+            NSLog(@"exit run loop.........: %zd", result);
         }
         NSLog(@"finishing thread.........");
     }

diff --git a/NSThreadExample/NSThreadExample/PTInputSource.m b/NSThreadExample/NSThreadExample/PTInputSource.m
@@ -11,15 +11,17 @@
 
 @implementation RunLoopSource
 
-- (id)init
+- (instancetype)init
 {
-    CFRunLoopSourceContext context = {0, (__bridge void *)(self), NULL, NULL, NULL, NULL, NULL,
-        &RunLoopSourceScheduleRoutine,
-        RunLoopSourceCancelRoutine,
-        RunLoopSourcePerformRoutine};
-
-    runLoopSource = CFRunLoopSourceCreate(NULL, 0, &context);
-    commands = [[NSMutableArray alloc] init];
+    if (self = [super init]) {
+        CFRunLoopSourceContext context = {0, (__bridge void *)(self), NULL, NULL, NULL, NULL, NULL,
+            &RunLoopSourceScheduleRoutine,
+            RunLoopSourceCancelRoutine,
+            RunLoopSourcePerformRoutine};
+
+        runLoopSource = CFRunLoopSourceCreate(NULL, 0, &context);
+        commands = [[NSMutableArray alloc] init];
+    }
 
     return self;
 }

diff --git a/NSThreadExample/NSThreadExampleTests/NSThreadExampleTests-Info.plist b/NSThreadExample/NSThreadExampleTests/NSThreadExampleTests-Info.plist
@@ -7,7 +7,7 @@
 	<key>CFBundleExecutable</key>
 	<string>${EXECUTABLE_NAME}</string>
 	<key>CFBundleIdentifier</key>
-	<string>com.kiloapp.${PRODUCT_NAME:rfc1034identifier}</string>
+	<string>$(PRODUCT_BUNDLE_IDENTIFIER)</string>
 	<key>CFBundleInfoDictionaryVersion</key>
 	<string>6.0</string>
 	<key>CFBundlePackageType</key>

diff --git a/NSURLConnectionExample/NSURLConnectionExample.xcodeproj/project.pbxproj b/NSURLConnectionExample/NSURLConnectionExample.xcodeproj/project.pbxproj
@@ -212,7 +212,7 @@
 			isa = PBXProject;
 			attributes = {
 				CLASSPREFIX = PT;
-				LastUpgradeCheck = 0500;
+				LastUpgradeCheck = 0700;
 				ORGANIZATIONNAME = KiloApp;
 				TargetAttributes = {
 					F44D2A6117798A5C00B48C77 = {
@@ -338,6 +338,7 @@
 				CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
 				"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer";
 				COPY_PHASE_STRIP = NO;
+				ENABLE_TESTABILITY = YES;
 				GCC_C_LANGUAGE_STANDARD = gnu99;
 				GCC_DYNAMIC_NO_PIC = NO;
 				GCC_OPTIMIZATION_LEVEL = 0;
@@ -396,6 +397,7 @@
 				GCC_PRECOMPILE_PREFIX_HEADER = YES;
 				GCC_PREFIX_HEADER = "NSURLConnectionExample/NSURLConnectionExample-Prefix.pch";
 				INFOPLIST_FILE = "NSURLConnectionExample/NSURLConnectionExample-Info.plist";
+				PRODUCT_BUNDLE_IDENTIFIER = "com.kiloapp.${PRODUCT_NAME:rfc1034identifier}";
 				PRODUCT_NAME = "$(TARGET_NAME)";
 				WRAPPER_EXTENSION = app;
 			};
@@ -409,6 +411,7 @@
 				GCC_PRECOMPILE_PREFIX_HEADER = YES;
 				GCC_PREFIX_HEADER = "NSURLConnectionExample/NSURLConnectionExample-Prefix.pch";
 				INFOPLIST_FILE = "NSURLConnectionExample/NSURLConnectionExample-Info.plist";
+				PRODUCT_BUNDLE_IDENTIFIER = "com.kiloapp.${PRODUCT_NAME:rfc1034identifier}";
 				PRODUCT_NAME = "$(TARGET_NAME)";
 				WRAPPER_EXTENSION = app;
 			};
@@ -430,6 +433,7 @@
 					"$(inherited)",
 				);
 				INFOPLIST_FILE = "NSURLConnectionExampleTests/NSURLConnectionExampleTests-Info.plist";
+				PRODUCT_BUNDLE_IDENTIFIER = "com.kiloapp.${PRODUCT_NAME:rfc1034identifier}";
 				PRODUCT_NAME = "$(TARGET_NAME)";
 				TEST_HOST = "$(BUNDLE_LOADER)";
 				WRAPPER_EXTENSION = xctest;
@@ -448,6 +452,7 @@
 				GCC_PRECOMPILE_PREFIX_HEADER = YES;
 				GCC_PREFIX_HEADER = "NSURLConnectionExample/NSURLConnectionExample-Prefix.pch";
 				INFOPLIST_FILE = "NSURLConnectionExampleTests/NSURLConnectionExampleTests-Info.plist";
+				PRODUCT_BUNDLE_IDENTIFIER = "com.kiloapp.${PRODUCT_NAME:rfc1034identifier}";
 				PRODUCT_NAME = "$(TARGET_NAME)";
 				TEST_HOST = "$(BUNDLE_LOADER)";
 				WRAPPER_EXTENSION = xctest;

diff --git a/NSURLConnectionExample/NSURLConnectionExample/NSURLConnectionExample-Info.plist b/NSURLConnectionExample/NSURLConnectionExample/NSURLConnectionExample-Info.plist
@@ -9,7 +9,7 @@
 	<key>CFBundleExecutable</key>
 	<string>${EXECUTABLE_NAME}</string>
 	<key>CFBundleIdentifier</key>
-	<string>com.kiloapp.${PRODUCT_NAME:rfc1034identifier}</string>
+	<string>$(PRODUCT_BUNDLE_IDENTIFIER)</string>
 	<key>CFBundleInfoDictionaryVersion</key>
 	<string>6.0</string>
 	<key>CFBundleName</key>

diff --git a/NSURLConnectionExample/NSURLConnectionExample/PTOperationDownloader.m b/NSURLConnectionExample/NSURLConnectionExample/PTOperationDownloader.m
@@ -14,10 +14,10 @@ @interface PTOperationDownloader()
 @property(nonatomic, readwrite, retain) NSMutableData* responseData;
 @property(nonatomic, readwrite, retain) NSURLConnection* connection;
 @property(nonatomic, readwrite, assign) NSTimeInterval timeoutInterval;
-@property(nonatomic, readwrite, copy) completionBlock completionBlock;
+@property(nonatomic, readwrite, copy) completionBlock customCompletionBlock;
 @property(nonatomic, readwrite, retain) NSError *error;
-@property(atomic, readwrite, assign) BOOL finished;
-@property(atomic, readwrite, assign) BOOL executing;
+@property(atomic, readwrite, assign) BOOL customFinished;
+@property(atomic, readwrite, assign) BOOL customExecuting;
 @property(nonatomic, readwrite, strong) NSRecursiveLock *lock;
 @end
 
@@ -63,7 +63,7 @@ - (void)setCompletionBlockWithSuccess:(void (^)(id responseData))success
 {
     [self.lock lock];
     __weak typeof(self) weakSelf = self;
-    self.completionBlock = ^ {
+    self.customCompletionBlock = ^ {
         if (weakSelf.error) {
             if (failure) {
                 failure(weakSelf.error);
@@ -100,14 +100,14 @@ - (void)start
     if ([self isCancelled])
     {
         [self willChangeValueForKey:@"isFinished"];
-        self.finished = YES;
+        self.customFinished = YES;
         [self didChangeValueForKey:@"isFinished"];
         return;
     }
 
     [self willChangeValueForKey:@"isExecuting"];
     [self performSelector:@selector(operationDidStart) onThread:[[self class] networkThread] withObject:nil waitUntilDone:NO];
-    self.executing = YES;
+    self.customExecuting = YES;
     [self didChangeValueForKey:@"isExecuting"];
     [self.lock unlock];
 }
@@ -134,8 +134,8 @@ - (void)operationDidFinish
     [self willChangeValueForKey:@"isFinished"];
     [self willChangeValueForKey:@"isExecuting"];
 
-    self.executing = NO;
-    self.finished = YES;
+    self.customExecuting = NO;
+    self.customFinished = YES;
 
     [self didChangeValueForKey:@"isExecuting"];
     [self didChangeValueForKey:@"isFinished"];
@@ -185,7 +185,7 @@ - (void)connection:(NSURLConnection *)aConnection didReceiveResponse:(NSURLRespo
         self.error = error;
         self.connection = nil;
         self.responseData = nil;
-        self.completionBlock();
+        self.customCompletionBlock();
     }
 }
 
@@ -198,7 +198,7 @@ - (void)connectionDidFinishLoading:(NSURLConnection *)aConnection
 {
     NSLog(@"connectionDidFinishLoading in main thread?: %d", [NSThread isMainThread]);
     self.connection = nil;
-    self.completionBlock();
+    self.customCompletionBlock();
     [self operationDidFinish];
 }
 
@@ -207,7 +207,7 @@ - (void)connection:(NSURLConnection *)connection didFailWithError:(NSError *)err
     self.connection = nil;
     self.responseData = nil;
     self.error = error;
-    self.completionBlock();
+    self.customCompletionBlock();
     [self operationDidFinish];
 }
 

diff --git a/NSURLConnectionExample/NSURLConnectionExample/PTViewController.m b/NSURLConnectionExample/NSURLConnectionExample/PTViewController.m
@@ -53,7 +53,7 @@ - (void)toggleButton
                                       downloadWithURL:[NSURL URLWithString:URLString]
                                       timeoutInterval:15
                                       success:^(id responseData){
-                                          NSLog(@"get data size: %d", [(NSData *)responseData length]);
+                                          NSLog(@"get data size: %zd", [(NSData *)responseData length]);
                                           NSLog(@"success block in main thread?: %d", [NSThread isMainThread]);
                                       }
                                       failure:^(NSError *error){

diff --git a/NSURLConnectionExample/NSURLConnectionExampleTests/NSURLConnectionExampleTests-Info.plist b/NSURLConnectionExample/NSURLConnectionExampleTests/NSURLConnectionExampleTests-Info.plist
@@ -7,7 +7,7 @@
 	<key>CFBundleExecutable</key>
 	<string>${EXECUTABLE_NAME}</string>
 	<key>CFBundleIdentifier</key>
-	<string>com.kiloapp.${PRODUCT_NAME:rfc1034identifier}</string>
+	<string>$(PRODUCT_BUNDLE_IDENTIFIER)</string>
 	<key>CFBundleInfoDictionaryVersion</key>
 	<string>6.0</string>
 	<key>CFBundlePackageType</key>