changed the way internals are exposed. #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johannes-Schneider
requested review from
cmfcmf,
luminosuslight and
msoechting
luminosuslight
approved these changes
Jan 30, 2018
|
are we sure |
justus-hildebrand
approved these changes
Jan 30, 2018
cmfcmf
approved these changes
Jan 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way is much cleaner, since the variables in the anonymous namespace are no longer there. Furthermore, the internals are no longer const, which enables the user to change them (this is required for almost all v8 methods).
Additionally, the internal getters are now within the
node::lib::internalnamespace, which indicates that the user has to know what shes doing. (we should provide some more documentation once the PR is merged)