Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UX of Squit package chooser #346

Merged
merged 8 commits into from
Sep 14, 2022
Merged

Improve UX of Squit package chooser #346

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6f3dcd1
Package chooser: Add cancel button, colorize buttons
LinqLover Oct 26, 2021
251a8e5
Add support for multiselection in package chooser
LinqLover Oct 26, 2021
57b088d
package chooser: when tracking multiple packages at once, remove all …
LinqLover Sep 9, 2022
97619a5
package chooser: scroll newly tracked/untracked packages into view
LinqLover Sep 9, 2022
9e9f065
package chooser: always sort tracked packages
LinqLover Sep 13, 2022
587e6a4
package chooser: unselect untracked packages before tracking/untracki…
LinqLover Sep 13, 2022
d98d888
package chooser: add menus for tracked/untracked list to control sele…
LinqLover Sep 13, 2022
87708b2
Merge branch 'develop' into feat/package-chooser-ux
LinqLover Sep 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Package chooser: Add cancel button, colorize buttons
  • Loading branch information
@LinqLover
LinqLover committed Oct 26, 2021
commit 6f3dcd1888dffcf5f5fa21b3941c0ac06ea8ed3b
4 changes: 4 additions & 0 deletions src/Squit.package/SquitPackageChooser.class/instance/acceptColor.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
toolbuilder
acceptColor
^ self userInterfaceTheme acceptColor
ifNil: [self userInterfaceTheme get: #okColor for: #DialogWindow]
10 changes: 9 additions & 1 deletion src/Squit.package/SquitPackageChooser.class/instance/buildWith..st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,14 @@ buildWith: builder
builder pluggableButtonSpec new
model: self;
label: 'Accept';
action: #accept}))
action: #accept;
color: #acceptColor;
yourself.
builder pluggableButtonSpec new
model: self;
label: 'Cancel';
action: #cancel;
color: #cancelColor;
yourself}))
addKeyboardCaptureFilter: self;
yourself
5 changes: 5 additions & 0 deletions src/Squit.package/SquitPackageChooser.class/instance/cancel.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
actions
cancel

acceptChanges := false.
self changed: #close
4 changes: 4 additions & 0 deletions src/Squit.package/SquitPackageChooser.class/instance/cancelColor.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
toolbuilder
cancelColor
^ self userInterfaceTheme cancelColor
ifNil: [self userInterfaceTheme get: #cancelColor for: #DialogWindow]
5 changes: 4 additions & 1 deletion src/Squit.package/SquitPackageChooser.class/methodProperties.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,14 @@
"chooseFor:" : "TB 4/22/2018 00:45" },
"instance" : {
"accept" : "TB 4/22/2018 12:40",
"acceptColor" : "ct 10/26/2021 14:29",
"buildButtons:" : "TB 4/22/2018 11:47",
"buildTrackedList:" : "TB 4/22/2018 13:32",
"buildUntrackedList:" : "TB 4/22/2018 13:32",
"buildWith:" : "TB 4/22/2018 13:17",
"buildWith:" : "ct 10/26/2021 14:29",
"buttonWidth" : "TB 4/22/2018 11:44",
"cancel" : "ct 10/26/2021 14:31",
"cancelColor" : "ct 10/26/2021 14:29",
"categoriesPlusPrefixes" : "TB 4/22/2018 00:37",
"chooseFor:" : "jr 5/6/2018 18:48",
"chooseSubdirectory:ifCanceled:" : "jr 9/6/2020 14:39",
Expand Down