-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
added tradition breaker, marking for long runtime tests
- Loading branch information
Matthias Barkowsky
committed
Jul 21, 2014
1 parent
3250203
commit ad27958
Showing
180 changed files
with
573 additions
and
58 deletions.
There are no files selected for viewing
4 changes: 4 additions & 0 deletions
4
packages/SwaLint-Core.package/SLClassTestObject.class/instance/testClassSuperclass.st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
accessing | ||
testClassSuperclass | ||
|
||
^ self testSystem classForTestClass: self testObject superclass |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
packages/SwaLint-Core.package/SLPlugIn.class/instance/methodListResult..st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
results | ||
methodListResult: aMethodCollection | ||
|
||
^((self collectionResult: aMethodCollection) | ||
showRule: [:items | items size > 0]) formatAsMethodList |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 6 additions & 0 deletions
6
packages/SwaLint-Core.package/SLSystemTestObject.class/instance/classForTestClass..st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
accessing | ||
classForTestClass: aClass | ||
|
||
^ allClasses | ||
detect: [ :any | any testObject = aClass] | ||
ifNone: [nil] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 8 additions & 0 deletions
8
packages/SwaLint-Core.package/SLTestData.class/instance/format.st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
displaying | ||
format | ||
|
||
| display | | ||
|
||
display := self name. | ||
self longRuntime ifTrue: [display := '*', display]. | ||
^ display |
4 changes: 4 additions & 0 deletions
4
packages/SwaLint-Core.package/SLTestData.class/instance/longRuntime..st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
accessing | ||
longRuntime: anObject | ||
|
||
longRuntime := anObject |
4 changes: 4 additions & 0 deletions
4
packages/SwaLint-Core.package/SLTestData.class/instance/longRuntime.st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
accessing | ||
longRuntime | ||
|
||
^ longRuntime |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
31368e27-ea6f-c44d-a5b4-c107b9b04d08 | ||
9ad5dde2-ce6f-7c46-96d8-ea35c6508457 |
1 change: 1 addition & 0 deletions
1
...package/monticello.meta/version.d/SwaLint-Core-MB.36_c5da1959-dcee-5f45-8309-a17989920b79
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
...package/monticello.meta/version.d/SwaLint-Core-MB.37_aaf46474-80fd-574d-ab4b-e0a57d82dd7f
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
...package/monticello.meta/version.d/SwaLint-Core-MB.38_9ad5dde2-ce6f-7c46-96d8-ea35c6508457
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 7 additions & 0 deletions
7
packages/SwaLint-PlugIns.package/SLDisharmonyPlugIn.class/class/basicClasses.st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
test-data | ||
basicClasses | ||
"Classes that should not cause Tradition Breaker" | ||
|
||
^ { | ||
Object. ProtoObject. Class. Behavior. | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
.../SwaLint-PlugIns.package/SLDisharmonyPlugIn.class/instance/excessiveInterfaceIncrease..st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
private | ||
excessiveInterfaceIncrease: aSLClassTestObject | ||
|
||
^ ((aSLClassTestObject resultOf: #classNAS) >= #average) and: | ||
[(aSLClassTestObject resultOf: #classPNAS) >= (2/3)] |
4 changes: 4 additions & 0 deletions
4
packages/SwaLint-PlugIns.package/SLDisharmonyPlugIn.class/instance/hasRelevantSuperclass..st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
private | ||
hasRelevantSuperclass: aSLClassTestObject | ||
|
||
^ ((self class basicClasses) includes: aSLClassTestObject testObject superclass) not |
14 changes: 14 additions & 0 deletions
14
...s/SwaLint-PlugIns.package/SLDisharmonyPlugIn.class/instance/parentNeitherSmallNorDumb..st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
private | ||
parentNeitherSmallNorDumb: aSLClassTestObject | ||
"returns false if parent is not selected or is included in basicClasses (see class side)" | ||
|
||
| parent | | ||
|
||
(self hasRelevantSuperclass: aSLClassTestObject) | ||
ifTrue: [parent := aSLClassTestObject testClassSuperclass] | ||
ifFalse: [^ false]. | ||
parent ifNil: [^ false] | ||
ifNotNil: [^ | ||
(((parent resultOf: #classAMW) > #average) or: | ||
[(parent resultOf: #weightedMethodCount) >= #veryHigh]) and: | ||
[(parent resultOf: #numberOfMethods) >= #high]] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 6 additions & 0 deletions
6
...waLint-PlugIns.package/SLDisharmonyPlugIn.class/instance/substantialSizeAndComplexity..st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
private | ||
substantialSizeAndComplexity: aSLClassTestObject | ||
|
||
^ (((aSLClassTestObject resultOf: #classAMW) > #average) or: | ||
[(aSLClassTestObject resultOf: #weightedMethodCount) >= #veryHigh]) and: | ||
[(aSLClassTestObject resultOf: #numberOfMethods) >= #high] |
9 changes: 9 additions & 0 deletions
9
packages/SwaLint-PlugIns.package/SLDisharmonyPlugIn.class/instance/traditionBreaker..st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
tests | ||
traditionBreaker: aSLClassTestObject | ||
|
||
aSLClassTestObject shouldBeClass. | ||
|
||
^ self successResult: | ||
((self excessiveInterfaceIncrease: aSLClassTestObject) and: | ||
[self substantialSizeAndComplexity: aSLClassTestObject] and: | ||
[self parentNeitherSmallNorDumb: aSLClassTestObject]) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
packages/SwaLint-PlugIns.package/SLMethodMetricsPlugIn.class/instance/methodCDISP..st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
1d27705d-84fb-4b42-b27b-87426b46bd90 | ||
6635c57c-c80d-cd46-8f29-20d418031551 |
1 change: 1 addition & 0 deletions
1
...kage/monticello.meta/version.d/SwaLint-PlugIns-MB.38_4b99c0e5-8d8f-9b49-93b9-afc2fa1437ed
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
...kage/monticello.meta/version.d/SwaLint-PlugIns-MB.39_9efb0982-312f-3446-b8df-d48d97ed3eee
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
...kage/monticello.meta/version.d/SwaLint-PlugIns-MB.40_6635c57c-c80d-cd46-8f29-20d418031551
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 0 additions & 2 deletions
2
packages/SwaLint-TestClasses.package/SLTestSubClass.class/instance/bar.st
This file was deleted.
Oops, something went wrong.
2 changes: 0 additions & 2 deletions
2
packages/SwaLint-TestClasses.package/SLTestSubClass.class/instance/foo.st
This file was deleted.
Oops, something went wrong.
2 changes: 0 additions & 2 deletions
2
packages/SwaLint-TestClasses.package/SLTestSubClass.class/instance/foobar.st
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.