Skip to content

Release 3.0.2 for adding support for OpenShift 4.20 #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Release 3.0.2 for adding support for OpenShift 4.20 #433

wants to merge 1 commit into from

Conversation

@rohit-balakrishna
Copy link
Collaborator

@rohit-balakrishna rohit-balakrishna commented Nov 20, 2025

  • make community community-deploy community-scorecard certified successful

dileepds
dileepds reviewed Nov 20, 2025
View reviewed changes
Copy link
Collaborator

@dileepds dileepds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can add the yaml files also for 3.0.2, same as the following . I think we missed this for 3.0.1 also and Michael added it later.

helm/values/csi-driver/v3.0.1
yaml/csi-driver/v3.0.1

@rohit-balakrishna
Copy link
Collaborator Author

rohit-balakrishna commented Nov 20, 2025 •
edited
Loading

I think we can add the yaml files also for 3.0.2, same as the following . I think we missed this for 3.0.1 also and Michael added it later.

helm/values/csi-driver/v3.0.1 yaml/csi-driver/v3.0.1

Should we do this now? Or once the release is complete, we copy the edge to v3.0.2 ? From what I remember we did this after the release previously.

@dileepds
Copy link
Collaborator

dileepds commented Nov 20, 2025

I think we can add the yaml files also for 3.0.2, same as the following . I think we missed this for 3.0.1 also and Michael added it later.
helm/values/csi-driver/v3.0.1 yaml/csi-driver/v3.0.1

Should we do this now? Or once the release is complete, we copy the edge to v3.0.2 ? From what I remember we did this after the release previously.

Yes, earlier we used to do include that in the same PR. I think we missed that for 3.0.0. I just checked the PR for 2.5.2 and confirmed - #414

datamattsson
datamattsson requested changes Nov 20, 2025
View reviewed changes
@rohit-balakrishna
Copy link
Collaborator Author

rohit-balakrishna commented Nov 21, 2025

I think we can add the yaml files also for 3.0.2, same as the following . I think we missed this for 3.0.1 also and Michael added it later.
helm/values/csi-driver/v3.0.1 yaml/csi-driver/v3.0.1

Should we do this now? Or once the release is complete, we copy the edge to v3.0.2 ? From what I remember we did this after the release previously.

Yes, earlier we used to do include that in the same PR. I think we missed that for 3.0.0. I just checked the PR for 2.5.2 and confirmed - #414

Ok, will add it in the latest commit.

@rohit-balakrishna
Release 3.0.2 for adding support for Openshift 4.20
6e56466 
 * make community community-deploy community-scorecard certified successful
 * incorporated review comments

Signed-off-by: Rohit Balakrishna <rohit.balakrishna@hpe.com>
dileepds
dileepds approved these changes Nov 21, 2025
View reviewed changes
Copy link
Collaborator

@dileepds dileepds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

datamattsson
datamattsson approved these changes Nov 21, 2025
View reviewed changes
Copy link
Collaborator

@datamattsson datamattsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes e2e on OpenShift 4.20, block and built-in NFS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@datamattsson datamattsson datamattsson approved these changes

@dileepds dileepds dileepds approved these changes

@raunakkumar raunakkumar Awaiting requested review from raunakkumar raunakkumar is a code owner

@suneeth51 suneeth51 Awaiting requested review from suneeth51 suneeth51 is a code owner

@sijeesh sijeesh Awaiting requested review from sijeesh sijeesh is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rohit-balakrishna @dileepds @datamattsson