Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match charm messages #141

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

Match charm messages #141

wants to merge 9 commits into from

Conversation

zoreoo
Copy link
Collaborator

@zoreoo zoreoo commented Oct 14, 2024

In a separate function for now

@zoreoo
Copy link
Collaborator Author

zoreoo commented Oct 18, 2024

It turns out that Event IDs are not as globally unique as I thought they were, so some messages were being mismatched with others. I fixed this by matching the message receives (entry method enters) with the most recent message send with the same event ID, but it will still possibly cause issues if messages with the same event ID were to overlap in time. I don't know if it is possible for them to overlap or how projections accounts for this (if it does and if it even needs to). For now, though, it seems that basically all messages are being properly matched in the tests I've used.

Another thing I don't really understand: it appears that some entry methods are split into portions (each a separate enter event) by "dummy_thread_ep" in the ping-pong projections trace. Each of those portions are matched to the same message send in the projections GUI, even though it's not multi- or broad-cast. Matching here still works with my implementation, it's just that the matching event in the send event's columns will have the index/timestamp of the last of these portions.

@zoreoo
Copy link
Collaborator Author

zoreoo commented Oct 18, 2024

One other thing that needs to be addressed: right now, the messages are being matched from Instant send events to Enter (receive) events that mark the beginning of an entry method.

The problem is, in the enter events this would overwrite the matching event from _match_events (or from the reader in the new implementation). I'm guessing this warrants a new column.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants