Skip to content

feat: add keyboard navigation for select charts #4481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: add keyboard navigation for select charts #4481

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/release-please.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ jobs:
uses: actions/checkout@v4

- name: Initialize Release Please
if: ${{ github.event_name == 'push' }}
id: release
uses: googleapis/release-please-action@v4
with:
Expand Down
126 changes: 120 additions & 6 deletions packages/chart/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,42 @@
margin-top: 50px;
}

#placeholder {
.controls {
max-width: 800px;
margin: 20px auto;
padding: 15px;
background-color: #fff;
border-radius: 5px;
box-shadow: 0 2px 4px rgba(0, 0, 0, 0.1);
}

.control-group {
margin: 10px 0;
}

.control-group label {
display: flex;
align-items: center;
cursor: pointer;
font-size: 14px;
}

.control-group input[type="checkbox"] {
margin-right: 10px;
cursor: pointer;
width: 18px;
height: 18px;
}

.control-group .description {
margin-left: 28px;
font-size: 12px;
color: #666;
font-style: italic;
}

#placeholder,
#placeholder2 {
width: 100%;
height: 500px;
background-color: #fff;
Expand All @@ -29,9 +64,31 @@

<body onresize="doResize()">
<h1>ESM Quick Test</h1>
<div id="placeholder"></div>

<div class="controls">
<div class="control-group">
<label>
<input type="checkbox" id="tabNavigationToggle">
Enable Tab Navigation for Column Chart
</label>
<div class="description">
When enabled, you can use Tab to navigate through columns and Space/Enter to select them
</div>
</div>
<div class="control-group">
<label>
<input type="checkbox" id="tabNavigationTogglePie">
Enable Tab Navigation for Pie Chart
</label>
<div class="description">
When enabled, you can use Tab to navigate through slices and Space/Enter to select them
</div>
</div>
</div>

<div id="placeholder" tabindex="0"></div>
<script type="module">
import { Area, Column } from "@hpcc-js/chart";
import { Area, Bar, Column, Pie } from "./src/index.ts";

const simple = {
ND: {
Expand All @@ -57,7 +114,7 @@ <h1>ESM Quick Test</h1>
}
};

window.__widget = new Column()
window.__column = new Column()
.target("placeholder")
.columns(["Category", "Series-1", "Series-2"])
.data([
Expand All @@ -70,14 +127,71 @@ <h1>ESM Quick Test</h1>
])
.tooltipValueFormat(",.0f")
.showValue(true)
.xAxisFocus(true)
.xAxisFocus(false)
.tabNavigation(false) // Start with tab navigation disabled
.render()
;

// window.__column = new Pie()
// .target("placeholder")
// .columns(["Category", "Series-1", "Series-2"])
// .data([
// ["B", 55],
// ["C", 54],
// ["D", 80],
// ["E", 86],
// ["A", 34],
// ["F", 144]
// ])
// .render()
// ;
</script>

<div id="placeholder2" tabindex="0"></div>
<script type="module">
import { Area, Column, Pie } from "./src/index.ts";

window.__pie = new Pie()
.target("placeholder2")
.columns(["Category", "Series-1", "Series-2"])
.data([
["B", 55],
["C", 54],
["D", 80],
["E", 86],
["A", 34],
["F", 144]
])
.tabNavigation(false)
.render()
;
</script>
<script>

function doResize() {
window.__widget?.resize()?.render();
window.__column?.resize()?.render();
window.__pie?.resize()?.render();
}

// Add event listener for the checkbox
document.getElementById('tabNavigationToggle').addEventListener('change', function (e) {
window.__column
.tabNavigation(e.target.checked)
.lazyRender()
;
console.log('Tab Navigation:', e.target.checked);
});

// Add event listener for the checkbox
document.getElementById('tabNavigationTogglePie').addEventListener('change', function (e) {
window.__pie
.tabNavigation(e.target.checked)
.lazyRender()
;
console.log('Tab Navigation:', e.target.checked);
});


</script>
</body>

Expand Down
45 changes: 42 additions & 3 deletions packages/chart/src/Column.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,48 @@

.chart_Column .columnRect {
stroke: transparent;
border-width: 1.5px;
border-width: 2px;
}

.chart_Column .columnRect.selected {
stroke: red;
.chart_Column .dataCell.selected .columnRect {
stroke: #dc3545 !important;
stroke-width: 3px !important;
paint-order: fill stroke !important;
filter: drop-shadow(0 0 3px rgba(220, 53, 69, 0.4));
transition: all 0.2s ease;
}

.chart_Column .dataCell:hover .columnRect {
stroke: rgba(108, 117, 125, 0.6);
stroke-width: 2px;
filter: brightness(1.05);
}

.chart_Column .dataCell:focus .columnRect {
stroke: #007bff !important;
stroke-width: 3px !important;
paint-order: fill stroke !important;
filter: drop-shadow(0 0 3px rgba(0, 123, 255, 0.4));
transition: all 0.2s ease;
}

.chart_Column .dataCell.selected:focus .columnRect {
stroke: #6f42c1 !important;
filter: drop-shadow(0 0 3px rgba(111, 66, 193, 0.5));
}

.chart_Column .dataCell:focus-visible {
outline: none;
}

.chart_Column .dataCell[data-tabster-focusable] {
outline: none !important;
}

.chart_Column .dataCell:focus {
outline: none !important;
}

.chart_Column .dataCell:active {
outline: none !important;
}
Loading