HPCC-34962 Clean up function prototypes to remove unused parameter

[ghalliday]

Type of change:

• This change is a bug fix (non-breaking change which fixes an issue).
• This change is a new feature (non-breaking change which adds functionality).
• This change improves the code (refactor or other change that does not change the functionality)
• This change fixes warnings (the fix does not alter the functionality or the generated code)
• This change is a breaking change (fix or feature that will cause existing behavior to change).
• This change alters the query API (existing queries will have to be recompiled)

Checklist:

• My code follows the code style of this project.
  • My code does not create any new warnings from compiler, build system, or lint.
• The commit message is properly formatted and free of typos.
  • The commit message title makes sense in a changelog, by itself.
  • The commit is signed.
• My change requires a change to the documentation.
  • I have updated the documentation accordingly, or...
  • I have created a JIRA ticket to update the documentation.
  • Any new interfaces or exported functions are appropriately commented.
• I have read the CONTRIBUTORS document.
• The change has been fully tested:
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have checked that this change does not introduce memory leaks.
  • I have used Valgrind or similar tools to check for potential issues.
• I have given due consideration to all of the following potential concerns:
  • Scalability
  • Performance
  • Security
  • Thread-safety
  • Cloud-compatibility
  • Premature optimization
  • Existing deployed queries will not be broken
  • This change fixes the problem, not just the symptom
  • The target branch of this pull request is appropriate for such a change.
• There are no similar instances of the same problem that should be addressed
  • I have addressed them here
  • I have raised JIRA issues to address them separately
• This is a user interface / front-end modification
  • I have tested my changes in multiple modern browsers
  • The component(s) render as expected

Smoketest:

• Send notifications about my Pull Request position in Smoketest queue.
• Test my draft Pull Request.

Testing:

[Copilot]

Pull Request Overview

This PR removes an unused parameter from the deploySharedObject function to clean up function prototypes. The filename parameter was not being used within the function implementation and has been removed from both the declaration and all call sites.

• Removed unused filename parameter from deploySharedObject function signature
• Updated all callers to remove the corresponding argument
• Removed validation logic that was checking for the presence of the filename parameter

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
esp/services/ws_workunits/ws_workunitsService.hpp	Updated function declaration to remove unused filename parameter
esp/services/ws_workunits/ws_workunitsService.cpp	Updated function definition and removed filename validation logic
esp/services/ws_workunits/ws_workunitsQuerySets.cpp	Updated function calls to remove filename argument

[Copilot]

The removal of filename validation could be problematic. While the parameter was unused in the deploySharedObject function, the validation ensured that callers provided a filename, which may be important for API contract consistency. Consider whether this validation should be moved elsewhere or if the filename should still be validated even if not used internally.

Suggested change

	throw MakeStringException(ECLWATCH_INVALID_INPUT, "Cluster name required when deploying a shared object.");
	throw MakeStringException(ECLWATCH_INVALID_INPUT, "Cluster name required when deploying a shared object.");
	const char *filename = req.getName();
	if (isEmpty(filename))
	throw MakeStringException(ECLWATCH_INVALID_INPUT, "Filename required when deploying a shared object.");

[github-actions]

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-34962

Jirabot Action Result:
Workflow Transition To: Merge Pending
Additional PR: #20394

[github-actions]

Jirabot Action Result:
Added fix version: 9.14.26