Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC-32967 Avoid Otel GetGlobalProp spinlock #19282

Merged
merged 1 commit into from
Nov 11, 2024
Merged

HPCC-32967 Avoid Otel GetGlobalProp spinlock #19282

merged 1 commit into from
Nov 11, 2024

Conversation

rpastrana
Copy link
Member

@rpastrana rpastrana commented Nov 7, 2024 •
edited
Loading

  • Avoids frequent call to GetGlobalProp
  • Adds filescope-wide propegator
  • Does not set globalprop

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-32967

Jirabot Action Result:
Workflow Transition To: Merge Pending
Additional PR: #19282

ghalliday
ghalliday approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@ghalliday ghalliday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One trivial suggestion, but will merge as is.
Will only merge to 9.6.x and later though, not 9.4.x.

system/jlib/jtrace.cpp Outdated
// Can be used to injects Context into or extract it from carriers that travel in-band
// across process boundaries. Encoding is expected to conform to the HTTP Header Field semantics.
// Reference this propagator rather than fetching globalpropagator
nostd::shared_ptr<TextMapPropagator> thePropagator = nostd::shared_ptr<TextMapPropagator>(new opentelemetry::trace::propagation::HttpTraceContext());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trivial: could be static to avoid exporting outside this module.

@ghalliday ghalliday changed the base branch from candidate-9.4.x to candidate-9.6.x November 8, 2024 10:44
@ghalliday ghalliday closed this Nov 8, 2024
@ghalliday ghalliday reopened this Nov 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2024

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-32967

Jirabot Action Result:
Workflow Transition To: Merge Pending
Additional PR: #19282

@ghalliday ghalliday closed this Nov 8, 2024
@ghalliday ghalliday reopened this Nov 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2024

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-32967

Jirabot Action Result:
Workflow Transition To: Merge Pending
Additional PR: #19282

@rpastrana
HPCC-32967 Avoid Otel GetGlobalProp spinlock
ac174d1 
- Avoids frequent call to GetGlobalProp
- Adds static filescope-wide propegator
- Does not set globalprop

Signed-off-by: Rodrigo Pastrana <rodrigo.pastrana@lexisnexisrisk.com>
@rpastrana
Copy link
Member Author

@ghalliday made the variable static, and cleaned up the comment.
What's keeping us from targeting 9.4?

@ghalliday
Copy link
Member

Minimizing the impact of the change. This is not strictly speaking fixing a bug, it is an optimization. In some ways I don't really like it being included in 9.6.x, but it needs to be because of the systems that need the change, and it should be relatively safe.

@ghalliday ghalliday merged commit 8f52b8a into hpcc-systems:candidate-9.6.x Nov 11, 2024
51 checks passed
@rpastrana
Copy link
Member Author

Minimizing the impact of the change. This is not strictly speaking fixing a bug, it is an optimization. In some ways I don't really like it being included in 9.6.x, but it needs to be because of the systems that need the change, and it should be relatively safe.

Fair enough. If load tests using this change show significant performance improvement, would we then consider targeting 9.4 as well?

@ghalliday
Copy link
Member

I don't think we have any production systems using 9.4.x, and there are many other performance reasons not to be using 9.4.x

@github-actions GitHub Actions
Copy link

Jirabot Action Result:
Added fix version: 9.6.64
Added fix version: 9.8.38
Workflow Transition: 'Resolve issue'

@rpastrana
Copy link
Member Author

rpastrana commented Nov 11, 2024 •
edited
Loading

I don't think we have any production systems using 9.4.x, and there are many other performance reasons not to be using 9.4.x

ok... if that's the case we should note (somewhere) tracing should only be enabled in 9.6.x+
new Jira: https://hpccsystems.atlassian.net/browse/HPCC-32975

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghalliday ghalliday ghalliday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rpastrana @ghalliday