Skip to content

[API] add docstrings and initialization to apex amp, naive amp #3783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
May 23, 2023
Merged

[API] add docstrings and initialization to apex amp, naive amp #3783

merged 12 commits into from
May 23, 2023

Conversation

flybird11111
Copy link
Contributor

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234
#3730

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

add docstrings and initialization to apex amp, naive amp

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@flybird11111 flybird11111 added Run Build and Test API related to API changes labels May 19, 2023
@flybird11111 flybird11111 requested a review from ver217 May 19, 2023 08:54
@flybird11111 flybird11111 self-assigned this May 19, 2023
@github-actions
Copy link
Contributor

The code coverage for the changed files is 78%.

Click me to view the complete report
Name                                               Stmts   Miss  Cover
----------------------------------------------------------------------
colossalai/booster/mixed_precision/fp16_apex.py        5      1    80%
colossalai/booster/mixed_precision/fp16_naive.py       4      1    75%
----------------------------------------------------------------------
TOTAL                                                  9      2    78%

@github-actions
Copy link
Contributor

The code coverage for the changed files is %.

Click me to view the complete report
Name                                               Stmts   Miss  Cover
----------------------------------------------------------------------
colossalai/booster/mixed_precision/fp16_apex.py        6      1    83%
colossalai/booster/mixed_precision/fp16_naive.py       4      1    75%
----------------------------------------------------------------------
TOTAL                                                 10      2    80%

@ver217 ver217 merged commit e871e34 into hpcaitech:main May 23, 2023
FrankLeeeee pushed a commit that referenced this pull request May 24, 2023
* [mixed_precison] add naive amp demo

* [mixed_precison] add naive amp demo

* [api] add docstrings and initialization to apex amp, naive amp

* [api] add docstring to apex amp/ naive amp

* [api] add docstring to apex amp/ naive amp

* [api] add docstring to apex amp/ naive amp

* [api] add docstring to apex amp/ naive amp

* [api] add docstring to apex amp/ naive amp

* [api] add docstring to apex amp/ naive amp

* [api] fix

* [api] fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API related to API changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants