Skip to content

Fix/docker action #3266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 22, 2023
Merged

Conversation

liuzeming-yuxi
Copy link
Contributor

@liuzeming-yuxi liuzeming-yuxi commented Mar 27, 2023

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability

  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description

  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

fixes #3264

📝 What does this PR do?

Add an ARG VERSION in the Dockerfile to determine tag for Colossalai.
Bind the value version to ARG VERSION in workflows/release_docker_after_merge.yml

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@FrankLeeeee
Copy link
Contributor

Hi @liuzeming-yuxi , let me double check on this. Your code change might not work as the version branch is only created when the release post is published in https://github.com/hpcaitech/ColossalAI/releases. The workflow is like this:

  1. change version.txt to up the version
  2. trigger workflow to publish the release post and create the version branch (requires manual editing of the release post and clicking of the publish button)
  3. trigger workflow to publish the docker image

It is important to note that 2 & 3 happen at the same time when 1 is completed. Therefore, I think it is not viable to do git branch -b $version in the Dockerfile as the branch might not be created in the first place.

I will look into the docker image issue and get back to you. Appreciate that you found the bug, that's awesome! 🚀

@FrankLeeeee FrankLeeeee merged commit 4d29c0f into hpcaitech:main May 22, 2023
FrankLeeeee pushed a commit that referenced this pull request May 24, 2023
* [docker] Add ARG VERSION to determine the Tag

* [workflow] fixed the version in the release docker workflow

---------

Co-authored-by: liuzeming <liuzeming@4paradigm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: The version of ColossalAI in docker image is error
2 participants