Skip to content

[fx] meta registration compatibility #3253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 27, 2023
Merged

Conversation

1SAA
Copy link
Contributor

@1SAA 1SAA commented Mar 27, 2023

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

Pytorch added a lot of meta kernels in 1.13. Thus, we should not override those kernels written by Pytorch.

We should import meta kernels according to the version of pytorch.

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@1SAA 1SAA added auto-parallel related to the auto-parallel feature Run Build and Test labels Mar 27, 2023
@github-actions
Copy link
Contributor

The code coverage for the changed files is 5%.

Click me to view the complete report
Name                               Stmts   Miss  Cover
------------------------------------------------------
colossalai/fx/_compatibility.py       28     12    57%
colossalai/fx/_meta_regist_12.py     257    257     0%
colossalai/fx/_meta_regist_13.py      24     24     0%
------------------------------------------------------
TOTAL                                309    293     5%

@YuliangLiu0306 YuliangLiu0306 merged commit 02b0580 into hpcaitech:main Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-parallel related to the auto-parallel feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants