[autochunk] support multi outputs chunk search #2538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* reorder alphafold tests * unet * add unet test * update gpc * add autochunk available * update test utils * update test utils * code style * rename * update evoformer stack * simplify test * delete simple evoformer * update chunk result assert * update chunk assert * update diffuser test * skip duffuser test for now * init gpt * refactor op detect * refact pattern recog * update some op, fix view bug * update node * fix bug * fix bug * remove useless part * finish tf * code style * code style * update chunk select * support view list, fix many bugs * finish gpt test * update gpt test * fix a bug * refact some function, clearer * update doc * move a function * seperate find chunk info function * can run now * fix view bug * update memory estimate for multi out * support split in codegen * run multi out for transformer * add print memory * seperate node manager * finish gpt test * update alphafold assert * update tests * add benchmark * fix a bug * update benchmark * merge * remove benchmark
|
How is the speed? |
feifeibear
approved these changes
Feb 1, 2023
The speed loses about 3-4%. I will update a benchmark in next pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support multi outputs chunk search. Previously we only support single output chunk search. It is more flexible and improve performance by a large margin. For transformer, we reduce memory by 40% than previous search strategy.