Skip to content

[setup] make cuda extension build optional #2336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 5, 2023
Merged

[setup] make cuda extension build optional #2336

merged 4 commits into from
Jan 5, 2023

Conversation

FrankLeeeee
Copy link
Contributor

@FrankLeeeee FrankLeeeee commented Jan 5, 2023 •
edited
Loading

Overview

It will in the best interest of the user if they can install colossalai smoothly. Currently, we force the user to build CUDA extensions upon pip install, which leads to much convenience.

Issue Number

Fixed #2334

What does this PR do?

This PR make building CUDA extension optional in the setup.py.

# install without cuda ext
pip install colossalai

# install with cuda ext
CUDA_EXT=1 pip install colossalai

@FrankLeeeee FrankLeeeee merged commit f1bc241 into hpcaitech:main Jan 5, 2023
@FrankLeeeee FrankLeeeee deleted the hotfix/make-cuda-ext-optional branch January 26, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@feifeibear feifeibear feifeibear approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE]: Make CUDA extensions default to optional
2 participants
@FrankLeeeee @feifeibear