Add plugins for logging results #877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwikle-lanl
force-pushed
the
fix-results-locking
branch
from
5cc7735 to
a0328ff
Compare
Paul-Ferrell
previously approved these changes
Jun 24, 2025
docs/plugins/result_loggers.rst
Outdated
Comment on lines
22
to
30
| The common file logger is the simplest possible result logger. It logs all test results to a single | ||
| log file, located in a specified location. The format for configuring a common file logger consists | ||
| of the plugin type (``common_file``) and the destination of the log file: | ||
|
|
||
| .. code-block:: yaml | ||
| result_loggers: | ||
| - plugin: common_file | ||
| dest: /path/to/results.log | ||
|
|
There was a problem hiding this comment.
You should have a comment in here about the locking requirements.
lib/pavilion/config.py
Outdated
Comment on lines
475
to
481
| ExPathElem( | ||
| "result_log", | ||
| # Derive the default from the working directory, if a value isn't | ||
| # given. | ||
| help_text="Results are put in both the general log and a specific " | ||
| "results log. This defaults to 'results.log' in the default " | ||
| "working directory."), |
There was a problem hiding this comment.
You should have Pavilion print a deprecation warning and configure a common logger for this.
Paul-Ferrell
approved these changes
Jul 2, 2025
hwikle-lanl
added a commit
that referenced
this pull request
Jul 15, 2025
* Initial logging plugin * Progress towards result output plugins * Fix some things * Foo * Fix some errors * Foo * Progress * Foo * Foo * Fix flatten_results test * Fix flatten results test * Fix setup_logger unit test * Add common file logger plugin * --ammend * Remove maint command * Attempt to fix module tests * Fix series init test * Fix some module tests * Fix log cmd tests * Add unit test for series file logger * Improve flatten_results unit test * Fix style issues * Add unit test for common file logger * Fix _log_results command * Add documentation for result loggers * Restore result_log key * Add note about locking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code review checklist: