Skip to content
This repository has been archived by the owner on Jun 17, 2024. It is now read-only.

separate chat server from Botkit message pipeline #19

Open
shashank-aisera opened this issue Nov 23, 2017 · 6 comments
Open

separate chat server from Botkit message pipeline #19

shashank-aisera opened this issue Nov 23, 2017 · 6 comments

Comments

@shashank-aisera
Copy link

Can you keep the chat server separate so developers will have the flexibility to use any other web socket library or more control on sockets management.

Like, i want to have a separate chat server which will communicate to the Botkit server in the same way that happens with Slack and Facebook implementation of Bokit.

@gagan-bansal
Copy link

+1 Nice suggestion

@Naktibalda
Copy link
Contributor

Do you want to remove WebSocket code from https://github.com/howdyai/botkit/blob/dev/webchannel/lib/Sockets.js ?

@shashank-saxena
Copy link

yes

@gagan-bansal
Copy link

Let me put what I have understood. Consider facebook messenger also a websocket server where messenger has exposed API to interact with their web socket server. So in case of separate chat server you have to expose all API to login, connection and messages.

If both chat server and bot server are with you only then there would not be much advantage by making chat server separate, the current architecture is sufficient. But if you have something in mind of scale like firebase or deepstreeam.io then yes separate chat server would be of much use.

@Naktibalda can you explain a little more conceptual architecture of botkit with facebook and with webchannel.

@Naktibalda
Copy link
Contributor

I am not familiar with Facebook messenger integration or with differences between different websocket implementations at all. I am watching webchannel space because it is the only channel I currently use.

My understanding of Botkit architecture is that different "bots" aren't plugins to the core, but parallel implementations with slightly different APIs and some common hooks. Some other integrations expose HTTP endpoints too,

This proposal worries me because it would make Botkit incompatible with a version I use and it would make me care about implementation of websockets, but I am happier to ignore it.

@shashank-saxena
Copy link

@Naktibalda

agreed.

Thus, Websocket implementation could be optional those want to use botkit implemented web socket server can use that else those who wants to integrate their own web socket server and push those messages from botkit message pipeline. Just like implementing your own Express server with FB & Slack botkit app.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants