Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a Sender::factory_timeout method. #214

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ogoodman
Copy link

@ogoodman ogoodman commented May 26, 2018

This is in response to issue #211.

By allowing timeouts to be set for the factory, and also adding an option to enable a client to keep running with no connections, we make it possible for a client which has become disconnected for any reason (or was even unable to connect in the first place) to make repeated connection attempts.

A timeout can be set in connection_lost (using a Sender from the outgoing Handler, which is unfortunate, but perhaps unavoidable) and then a new connection can be created in the (newly added) on_timeout method of the factory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant