-
Notifications
You must be signed in to change notification settings - Fork 394
Upgrade to Ruby 3.1.4 and Rails 6.1 #1882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| @@ -1,5 +1,7 @@ | |||
| class BuildConfig | |||
| static_facade :call | |||
| def self.call(...) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unexpected token tDOT3
| @@ -1,5 +1,7 @@ | |||
| class RebuildPullRequest | |||
| static_facade :call | |||
| def self.call(...) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unexpected token tDOT3
| @@ -1,5 +1,7 @@ | |||
| class ReportInvalidConfig | |||
| static_facade :call | |||
| def self.call(...) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unexpected token tDOT3
| @@ -1,5 +1,7 @@ | |||
| class DeactivateRepo | |||
| static_facade :call | |||
| def self.call(...) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unexpected token tDOT3
| NUMBER_OF_BUILDS = 10 | ||
|
|
||
| static_facade :call | ||
| def self.call(...) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unexpected token tDOT3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR upgrades the application from Ruby 2.7.1 to Ruby 3.1.4 and Rails 6.0 to Rails 6.1, addressing breaking changes and updating dependencies accordingly.
Key changes:
- Upgrades Ruby runtime to 3.1.4 across all configuration files
- Upgrades Rails framework to 6.1.7.10 with updated gem dependencies
- Fixes Ruby 3.0+ keyword argument deprecations and YAML API changes
- Updates Webpacker from 4.x to 5.x with Node.js 20.x support
- Adds OpenSSL legacy provider flag for webpack compatibility
Reviewed changes
Copilot reviewed 16 out of 20 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
.ruby-version |
Updates Ruby version from 2.7.1 to 3.1.4 |
Gemfile |
Updates Ruby version and Rails to 6.1, adds required gems (logger, matrix, rexml) |
Gemfile.lock |
Updates all gem versions for Rails 6.1 and Ruby 3.1.4 compatibility |
package.json |
Updates Node.js to 20.x and Webpacker to 5.4.0, adds sass dependency |
yarn.lock |
Updates all npm packages for Webpacker 5 compatibility |
circle.yml |
Updates CI Docker image to Ruby 3.1.4 |
bin/webpack |
Adds OpenSSL legacy provider flag and logger require |
bin/webpack-dev-server |
Adds OpenSSL legacy provider flag and logger require |
config/boot.rb |
Adds logger require for Rails 6.1 compatibility |
spec/spec_helper.rb |
Adds logger require |
spec/support/helpers/analytics_helper.rb |
Renames module to avoid naming conflicts |
spec/rails_helper.rb |
Updates helper reference to match rename |
app/models/config/parser.rb |
Fixes YAML.safe_load API for Ruby 3.1 (keyword argument change) |
app/services/*.rb |
Replaces static_facade with explicit class method using ... forwarding |
app/queries/*.rb |
Replaces static_facade with explicit class method using ... forwarding |
spec/models/plan_selector_spec.rb |
Fixes keyword argument passing with ** operator |
spec/presenters/plan_presenter_spec.rb |
Fixes keyword argument passing with ** operator for Ruby 3.0+ |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.