feat: overhaul package registry script runners #808
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation assumes that the user always want to use a script runner like npx to run the tool, if a binary isn't found.
This makes sense for some tools, but it has the side effect of downloading external code to the users machine. Downloading extra code should be optional, not the default.
This PR addresses that issue by removing the
javascript_runtime
value from the config, and adding a new valuerunners
that allows the user to define which package runners should be enabled.