Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: overhaul package registry script runners #808

Merged
merged 10 commits into from
Mar 8, 2025

Conversation

hougesen
Copy link
Owner

@hougesen hougesen commented Mar 8, 2025

The current implementation assumes that the user always want to use a script runner like npx to run the tool, if a binary isn't found.

This makes sense for some tools, but it has the side effect of downloading external code to the users machine. Downloading extra code should be optional, not the default.

This PR addresses that issue by removing the javascript_runtime value from the config, and adding a new value runners that allows the user to define which package runners should be enabled.

{
  "runners": {
    "bunx": false,
    "deno": false,
    "npx": false,
    "pnpm": false,
    "pipx": false,
    "uv": false
  }
}

@hougesen hougesen added the enhancement New feature or request label Mar 8, 2025
@hougesen hougesen self-assigned this Mar 8, 2025
@hougesen hougesen marked this pull request as ready for review March 8, 2025 16:35
@hougesen hougesen merged commit 44d8117 into main Mar 8, 2025
16 checks passed
@hougesen hougesen deleted the feat/allow-disabling-script-runners branch March 8, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant