Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when morphing a page when visiting it for the second time #1080

Closed
brunoprietog opened this issue Nov 27, 2023 · 0 comments · Fixed by #1098
Closed

Error when morphing a page when visiting it for the second time #1080

brunoprietog opened this issue Nov 27, 2023 · 0 comments · Fixed by #1098

Comments

@brunoprietog
Copy link
Collaborator

With morphing enabled by default, when visiting a page with the 'replace' action, revisiting the previous page using the 'replace' action, and then revisiting the current page using the 'replace' action, an error occurs, and the body becomes null.

You can easily test the error at https://turbo-morph-error.fly.dev/

Visit the second page, then return to the first page by pressing the link, and then press the link to visit the first page again. You will see that the page remains blank.

From my perspective, what is happening is that in one of the renderings with morphing, the body is set to null after calling idiomorph. I tried debugging, but I only managed to notice that; I still don't understand the cause.

brunoprietog added a commit to brunoprietog/turbo that referenced this issue Dec 4, 2023
Fix Error when morphing a page when visiting it for the second time hotwired#1080
brunoprietog added a commit to brunoprietog/turbo that referenced this issue Dec 9, 2023
Fix Error when morphing a page when visiting it for the second time hotwired#1080
brunoprietog added a commit to brunoprietog/turbo that referenced this issue Dec 9, 2023
Fix Error when morphing a page when visiting it for the second time hotwired#1080
afcapel pushed a commit that referenced this issue Feb 1, 2024
Fix Error when morphing a page when visiting it for the second time #1080
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant