turbo:install:redis redis_installed? doesn't work on Windows

[mohits]

Installing rails and doing a rails new on Windows works perfectly well with one warning/ error that comes up when the rails new is running.

The system cannot find the path specified.

I have been able to track it down to redis_installed? at:

turbo-rails/lib/tasks/turbo_tasks.rake

Line 6 in acbb925

system('which redis-server > /dev/null')

The output is redirected to dev/null causes Windows to output that line (and of course, even if that was not the case which is not available on Windows).

As @dhh noted in #225 (comment) "it doesn't have to work perfectly everywhere" and I can confirm it does not :)

Just raising it here. Also, I have documented this on my post about Rails 7 + Windows that people don't need to worry too much about whether Rails was set up properly when they see that message.

[dhh]

Would be happy to take a PR that makes this work better on Windows.

[mohits]

Thanks @dhh.

Step 1 was identification.
Step 2 is finding the solution. Based on what I see and know, this will be closest to the correct solution. This also searches for redis-server using where instead of which, and redirects correctly to NUL for both stdout and stderr.

def redis_installed?
  Gem.win_platform? ?
    system('where redis-server > NUL 2>&1') : 
    system('which redis-server > /dev/null')
end

I have done some quick checks with this on Windows (CRuby and JRuby) using both Powershell and Command Prompt and it looks good. I will do a couple of checks on my Ubuntu VM later this week and then get into the process of the PR.

[mohits]

#300 is merged.
This is now closed.