Updated UI for order details page and implemented feature to select store pickup location (#85zru5e18) #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityasharma7
suggested changes
Mar 29, 2023
| order.line_items.map((item: any) => { | ||
| item.isBopis = item.properties.some((property: any) => property.name === "_pickupstore"); | ||
| if (item.isBopis) { | ||
| item.deliveryMethodTypeId = 'STOREPICKUP' |
There was a problem hiding this comment.
We should either decide upon the property or remove the deliveryMethodTypeId method upon saving the order. Adding a property could give uncertain behaviour
src/store/modules/order/actions.ts
Outdated
| if (item.isBopis) { | ||
| item.deliveryMethodTypeId = 'STOREPICKUP' | ||
| const facilityAddress = item.properties.find((property: any) => property.name == 'Store Pickup').value.split(', ') | ||
| item.selectedFacility = { facilityName: facilityAddress[0], address1: facilityAddress[1], city: facilityAddress[2] } |
There was a problem hiding this comment.
Maybe we could store the property value as is
src/store/modules/order/actions.ts
Outdated
| item.deliveryMethodTypeId = 'STANDARD' | ||
| } | ||
| }) | ||
| dispatch('stock/checkInventoryByFacility', productSkus, { root: true }); |
There was a problem hiding this comment.
I think this might not be needed
src/views/OrderDetail.vue
Outdated
| } else { | ||
| updateDeliveryMethod(event: any, item: any) { | ||
| item.deliveryMethodTypeId = event.detail.value; | ||
| item.properties = item.properties.filter((property: any) => !(property.name === '_pickupstore' || property.name === 'Store Pickup' || property.name === 'Pickup Store')) |
There was a problem hiding this comment.
I think we should handle the case when the bopis item is changed to delivery
src/views/PickupLocationModal.vue
Outdated
| async getStores(location: string) { | ||
| const payload = { | ||
| "viewSize": 50, | ||
| "filters": ["storeType: WAREHOUSE"], |
There was a problem hiding this comment.
We could make it configurable from .env
src/views/PickupLocationModal.vue
Outdated
|
|
||
| try { | ||
| const storeLookupResp = await FacilityService.getStores(payload) | ||
| if (storeLookupResp.status !== 200 || hasError(storeLookupResp) || !storeLookupResp.data.response.numFound) { |
There was a problem hiding this comment.
I think docs will already have empty array if no record found
Suggested change
| if (storeLookupResp.status !== 200 || hasError(storeLookupResp) || !storeLookupResp.data.response.numFound) { | |
| if (hasError(storeLookupResp)) { |
There was a problem hiding this comment.
storeLookup does not return any errors in case of failure. We can check for !storeLookupResp.data.response.numFound
src/views/PickupLocationModal.vue
Outdated
| } | ||
| }) | ||
|
|
||
| if (locationResp.status !== 200 || hasError(locationResp) || !locationResp.data.response.numFound) { |
There was a problem hiding this comment.
Suggested change
| if (locationResp.status !== 200 || hasError(locationResp) || !locationResp.data.response.numFound) { | |
| if ( hasError(locationResp) || !locationResp.data.response.numFound) { |
There was a problem hiding this comment.
In case of error, postcodeLookup returns an error field and omits the response field. So, I've added a check for !locationResp.response
src/views/PickupLocationModal.vue
Outdated
| "fieldsToSelect": ["atp", "facilityName", "facilityId"], | ||
| }); | ||
|
|
||
| if (hasError(productInventoryResp) || !productInventoryResp.data.count) { |
There was a problem hiding this comment.
Suggested change
| if (hasError(productInventoryResp) || !productInventoryResp.data.count) { | |
| if (hasError(productInventoryResp)) { |
src/views/PickupLocationModal.vue
Outdated
| if (!storesWithInventory?.length) return; | ||
|
|
||
| stores.map((storeData: any) => { | ||
| const inventoryDetails = storesWithInventory.filter((store: any) => store.facilityId === storeData.storeCode); |
There was a problem hiding this comment.
Suggested change
| const inventoryDetails = storesWithInventory.filter((store: any) => store.facilityId === storeData.storeCode); | |
| const inventoryDetails = storesWithInventory.find((store: any) => store.facilityId === storeData.storeCode); |
…ional checks for disabling the save button (#85zru5e18)
…Made to isChanged (#85zru5e18)
This was referenced Mar 30, 2023
adityasharma7
approved these changes
Mar 30, 2023
alsoK2maan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #22
Closes #20
Short Description and Why It's Useful
Screenshots of Visual Changes before/after (If There Are Any)
Contribution and Currently Important Rules Acceptance