Improved: added a comment for reason behind using outline css (#367)

hotwax · Apr 9, 2024 · c5eff28 · c5eff28
1 parent f4e0c87
commit c5eff28
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 0 deletions.
diff --git a/src/views/PurchaseOrderDetail.vue b/src/views/PurchaseOrderDetail.vue
@@ -443,6 +443,10 @@ ion-thumbnail {
 } 
 
 .scanned-item {
+  /*
+    Todo: used outline for highliting items for now, need to use border
+    Done this because currently ion-item inside ion-card is not inheriting highlighted background property.
+  */
   outline: 2px solid var( --ion-color-medium-tint);
 }
 

diff --git a/src/views/ReturnDetails.vue b/src/views/ReturnDetails.vue
@@ -306,6 +306,10 @@ export default defineComponent({
   }
 
   .scanned-item {
+    /*
+      Todo: used outline for highliting items for now, need to use border
+      Done this because currently ion-item inside ion-card is not inheriting highlighted background property.
+    */
     outline: 2px solid var( --ion-color-medium-tint);
   }
 </style>

diff --git a/src/views/ShipmentDetails.vue b/src/views/ShipmentDetails.vue
@@ -335,6 +335,10 @@ ion-thumbnail {
 }
 
 .scanned-item {
+  /*
+    Todo: used outline for highliting items for now, need to use border
+    Done this because currently ion-item inside ion-card is not inheriting highlighted background property.
+  */
   outline: 2px solid var( --ion-color-medium-tint);
 }
 </style>