Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented: details page for pre-order catalog (#85zt0m4qc) #137

Merged
merged 24 commits into from
Jun 23, 2023

Conversation

adityasharma7
Copy link
Contributor

Related Issues

Closes #128

Short Description and Why It's Useful

Screenshots of Visual Changes before/after (If There Are Any)

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change

Contribution and Currently Important Rules Acceptance

k2maan and others added 24 commits May 17, 2023 15:56
…bs section and improved code to show skeleton text (#85zt0m4qc)
…pty values and no responses in the UI (#85zt0m4qc)
…ing configs and logic for fetching jobs (#85zt0m4qc)
1. Improved action to handle cached data and forced update. Added try catch to handle errors
2. Improved getter, productStoreId should be passed instead of used from rootState. It would easier to reuse getter.
3. Fixed issue with update not working from second time, getters were used when passing the value and actions do not foce update
…ge (#85zt0m4qc)

Additionally removed logic to get fromDate using PreOrderCategoryProducts entity and used exisiting data from ProductDcsnReason
@adityasharma7 adityasharma7 merged commit c3d7979 into main Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants