Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: the routing from the query page to the route list page #79

Merged
merged 5 commits into from
Feb 14, 2024

Conversation

ymaheshwari1
Copy link
Contributor

@ymaheshwari1 ymaheshwari1 commented Feb 3, 2024

Related Issues

Closes #62

Short Description and Why It's Useful

Removed usage of ion-chip and replaced with ion-back-button to make the navigation work as expected and we don't need to handle the navigation from route details to the run details page using push that results in breaking the navigation from run details to runs page.

Screenshots of Visual Changes before/after (If There Are Any)

After:

image

When using color="medium" on ion-back-button (Not added in the code just added the screenshot)

image

Contribution and Currently Important Rules Acceptance

@dt2patel
Copy link
Contributor

dt2patel commented Feb 7, 2024

Are we required to use ion back button if we want to manage routing correctly? I feel like we should be allowed to add a corresponding pop/back action to any element we want right?

@ymaheshwari1
Copy link
Contributor Author

ymaheshwari1 commented Feb 9, 2024

Are we required to use ion back button if we want to manage routing correctly? I feel like we should be allowed to add a corresponding pop/back action to any element we want right?

We have method to go to specific page using router.go(number) in the route history, but as we have support to move to the settings page from the query page, if the user moves to the settings page a new route entry gets added in the history and when clicking back from query page, the user gets redirected to the settings page, as user is coming from the settings page.

The above method depends on the position of the route relative to the currentRoute.

…ic routes

When using router.go, the router does not always go to the route list from details page if the user moves to settings page from the details page, thus removed the tab-bar to be displayed on specific route, so that the routing works always as expected
@ymaheshwari1 ymaheshwari1 merged commit 7e73f4a into hotwax:main Feb 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Routing from Run List page to Run Details page
2 participants